Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Test case without done_testing exits with 0. #341

Merged
merged 1 commit into from Dec 10, 2012

Conversation

Projects
None yet
3 participants
Contributor

tokuhirom commented Nov 7, 2012

If Have_Plan is false, test script exit with status code 0. It's not expected behaviour i think.

Test case without done_testing exits with 0.
Failed test script should be return non-zero value.
Owner

schwern commented Nov 9, 2012

Good catch, every failing test should be non-zero. I'll have a closer look at it later, but looks good at a glance.

One question, why'd you pick 254? The specific exit codes don't matter too much any more, just curious.

Contributor

tokuhirom commented Nov 12, 2012

I don't any reason to use 254. There is no code for specific exit code. And one of the reason is 254 is not 255 🐼

schwern added a commit that referenced this pull request Dec 10, 2012

Merge pull request #341 from tokuhirom/exit_code_on_missing_done_testing
Test case without done_testing exits with 0.

@schwern schwern merged commit 8235f3e into Test-More:master Dec 10, 2012

Member

karenetheridge commented Apr 29, 2013

This is awesome, BTW. And - bonus! - it doesn't break my tests that fork, although I expected it to -- after digging through the code I discovered that the 'if not have a plan, exit with error' logic doesn't apply if the exiting process doesn't match the one that Test::Builder was constructed under.

Owner

schwern commented May 2, 2013

Great to hear! Not doing end-of-test actions in a child process has been in since 0.47, I'm glad it continues to just work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment