like() and unlike() no longer warn about undef. #372

Merged
merged 1 commit into from Apr 23, 2013

Projects

None yet

3 participants

@schwern
Member
schwern commented Apr 23, 2013

Not much sense, they can see it in the diagnostics, and the warning
message is a bit confusing.

Use of uninitialized value $this in pattern match (m//) at x:\test.t line 6.

It reports the right location, but there's no $this from the user's
perspective.

This came in because like used to supress all warnings. That was
fixed in 8b2f0c6 but it let
uninit warnings slip in.

Did it against master because it will merge nicely into Test-Builder1.5.

For #335.

@schwern schwern like() and unlike() no longer warn about undef.
Not much sense, they can see it in the diagnostics, and the warning
message is a bit confusing.

    Use of uninitialized value $this in pattern match (m//) at x:\test.t line 6.

It reports the right location, but there's no $this from the user's
perspective.

This came in because like used to supress all warnings.  That was
fixed in 8b2f0c6 but it let
uninit warnings slip in.

For #335.
9425e41
@dakkar
dakkar commented Apr 23, 2013

reviewed: I approve :)

@schwern schwern merged commit c21e0e6 into master Apr 23, 2013
@steffenw

Test::Simple 0.98
warns on
Test/Builder.pm line 1407
with
Use of uninitialized value $this in pattern match (m//)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment