New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch artifacts in parallel. Treat warnings as errors #376

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@bootstraponline
Contributor

bootstraponline commented Nov 2, 2018

Fix #323

downloadFile.parent.toFile().mkdirs()
blob.downloadTo(downloadFile)
runBlocking {
filtered.forEach { matrix ->

This comment has been minimized.

@winterDroid

winterDroid Nov 2, 2018

Contributor

should the amount of parallel executions be limited?

This comment has been minimized.

@bootstraponline

bootstraponline Nov 2, 2018

Contributor

with the current code, there's one parallel execution per matrix that's finished & not yet downloaded.

I don't think this will be a problem. The download requests for each matrix are still run synchronously.

if it is an issue then we could look into placing an upper limit on the amount of concurrency.

This comment has been minimized.

@bootstraponline

bootstraponline Nov 2, 2018

Contributor

https://github.com/Kotlin/kotlinx.coroutines/blob/d6a5a399d1724ff56bbb285b25df071dbc98b715/core/kotlinx-coroutines-core/src/CommonPool.kt#L23

If the property is not specified, Runtime.getRuntime().availableProcessors() - 1 will be used

Kotlin/kotlinx.coroutines#261

based on the above, looks like we're good

@bootstraponline bootstraponline merged commit 1e5815a into master Nov 2, 2018

3 of 4 checks passed

codecov/project 80.8% (-0.11%) compared to a59f0d5
Details
ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
license/cla Contributor License Agreement is signed.
Details

@bootstraponline bootstraponline deleted the parallel_artifacts branch Nov 2, 2018

sravanmedarapu added a commit to sravanmedarapu/flank that referenced this pull request Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment