New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files-to-download #441

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@winterDroid
Copy link
Contributor

winterDroid commented Dec 21, 2018

Support downloading directories after test run from the result bucket
Upgrade Guava to 25.1 due to NoSuchMethodError while running tests (see google/truth#473)
Fix missing download of PNGs after test run

@winterDroid

This comment has been minimized.

Copy link
Contributor

winterDroid commented Dec 21, 2018

Fixes #438

@winterDroid winterDroid force-pushed the winterDroid:dir-to-download branch 2 times, most recently from 430c9e8 to 36b5166 Dec 21, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #441 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #441      +/-   ##
============================================
- Coverage     79.16%   79.04%   -0.13%     
- Complexity      619      639      +20     
============================================
  Files            69       69              
  Lines          1781     1885     +104     
  Branches        271      303      +32     
============================================
+ Hits           1410     1490      +80     
- Misses          194      216      +22     
- Partials        177      179       +2

@Macarse Macarse requested a review from bootstraponline Dec 21, 2018

@Macarse

This comment has been minimized.

Copy link
Collaborator

Macarse commented Dec 21, 2018

@winterDroid What's the diff between directories-to-download and --directories-to-pull from #408?

@winterDroid

This comment has been minimized.

Copy link
Contributor

winterDroid commented Dec 21, 2018

This one will download the directories specified from the bucket to your local storage, the other one downloads from the device to the bucket

@Macarse

This comment has been minimized.

Copy link
Collaborator

Macarse commented Dec 21, 2018

Oh, I see. I guess the cmd is not part of gcloud and that's why it was not part of #365.
I wonder if we should add bucket to the cmd somehow to avoid confusion. Something like directories-to-download-from-bucket. wdyt?

@winterDroid

This comment has been minimized.

Copy link
Contributor

winterDroid commented Dec 21, 2018

I thought about that, but I think the problem with that is that it is hard to know the full path.. Maybe it would be better to have it files-to-download which takes a regex and not just a string..

@Macarse

This comment has been minimized.

Copy link
Collaborator

Macarse commented Jan 7, 2019

I tested this and it works as expected. I will test this on iOS tomorrow but it should work.
@bootstraponline plz review and merge 👍

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Jan 7, 2019

I'll take a look when I'm back at work tomorrow.

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Jan 8, 2019

Auto downloading pngs was intentionally removed because it's slow and there's no way to disable the behavior. I think the new dir-to-download feature will allow users to opt into downloading what they want (pngs included).

@bootstraponline bootstraponline force-pushed the winterDroid:dir-to-download branch from 3465ff4 to 5cb4c0f Jan 8, 2019

Add directories-to-download flag for Android Args
Support downloading directories after test run from the result bucket

@bootstraponline bootstraponline force-pushed the winterDroid:dir-to-download branch 2 times, most recently from 89da109 to c1bae01 Jan 8, 2019

@bootstraponline bootstraponline changed the title Add directories-to-download flag for Android Args Add files-to-download Jan 9, 2019

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Jan 9, 2019

Maybe it would be better to have it files-to-download which takes a regex and not just a string..

I think that's a great suggestion. I updated the code to work on a regex that downloads files.

@bootstraponline bootstraponline force-pushed the winterDroid:dir-to-download branch 4 times, most recently from f6e217f to 5afb681 Jan 9, 2019

@bootstraponline bootstraponline force-pushed the winterDroid:dir-to-download branch from 5afb681 to 8c4b0b4 Jan 9, 2019

@Macarse

This comment has been minimized.

Copy link
Collaborator

Macarse commented Jan 9, 2019

Tested on iOS and Android. Merge! 👍

@bootstraponline bootstraponline merged commit 5d52606 into TestArmada:master Jan 9, 2019

3 checks passed

ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
license/cla Contributor License Agreement is signed.
Details
@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Jan 9, 2019

The feature has been merged into Flank. It'll be part of the v4.2 release. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment