New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #484: Name with ':' breaks in windows #485

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@Sunil-plsr
Copy link
Contributor

Sunil-plsr commented Feb 1, 2019

Fixes #484

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Feb 1, 2019

CLA assistant check
All committers have signed the CLA.

@Sunil-plsr Sunil-plsr force-pushed the Sunil-plsr:sunil/issue484 branch from bfa5f0a to 58d84bc Feb 1, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #485   +/-   ##
=========================================
  Coverage     78.56%   78.56%           
  Complexity      667      667           
=========================================
  Files            73       73           
  Lines          1899     1899           
  Branches        282      282           
=========================================
  Hits           1492     1492           
  Misses          229      229           
  Partials        178      178

@Macarse Macarse requested a review from bootstraponline Feb 1, 2019

@Sunil-plsr Sunil-plsr force-pushed the Sunil-plsr:sunil/issue484 branch from 58d84bc to dda87c9 Feb 1, 2019

@bootstraponline bootstraponline merged commit 40f04d7 into TestArmada:master Feb 2, 2019

4 checks passed

ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
codecov/project 78.56% (+0%) compared to b17c887
Details
license/cla Contributor License Agreement is signed.
Details
@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Feb 2, 2019

Thanks for the pull request! Merged.

@bootstraponline bootstraponline referenced this pull request Feb 2, 2019

Closed

: breaks Windows #484

@Sunil-plsr Sunil-plsr deleted the Sunil-plsr:sunil/issue484 branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment