Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue #484: Name with ':' breaks in windows #485
Conversation
This comment has been minimized.
This comment has been minimized.
CLAassistant
commented
Feb 1, 2019
•
|
|
Sunil-plsr
force-pushed the
Sunil-plsr:sunil/issue484
branch
from
bfa5f0a
to
58d84bc
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=========================================
Coverage 78.56% 78.56%
Complexity 667 667
=========================================
Files 73 73
Lines 1899 1899
Branches 282 282
=========================================
Hits 1492 1492
Misses 229 229
Partials 178 178 |
Macarse
requested a review
from
bootstraponline
Feb 1, 2019
Sunil-plsr
force-pushed the
Sunil-plsr:sunil/issue484
branch
from
58d84bc
to
dda87c9
Feb 1, 2019
bootstraponline
approved these changes
Feb 2, 2019
bootstraponline
merged commit 40f04d7
into
TestArmada:master
Feb 2, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request! Merged. |
Sunil-plsr
deleted the
Sunil-plsr:sunil/issue484
branch
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Sunil-plsr commentedFeb 1, 2019
•
edited by bootstraponline
Fixes #484