Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use dash naming on flank yml params #519

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@bootstraponline
Copy link
Contributor

bootstraponline commented Mar 13, 2019

FlankYmlParams
    maxTestShards -> max-test-shards
    shardTime -> shard-time
    repeatTests -> repeat-tests
    smartFlankGcsPath -> smart-flank-gcs-path
    disableSharding -> disable-sharding
Update to use dash naming on flank yml params
FlankYmlParams
    maxTestShards -> max-test-shards
    shardTime -> shard-time
    repeatTests -> repeat-tests
    smartFlankGcsPath -> smart-flank-gcs-path
    disableSharding -> disable-sharding
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #519 into master will increase coverage by 0.21%.
The diff coverage is 92.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #519      +/-   ##
============================================
+ Coverage     80.16%   80.38%   +0.21%     
- Complexity      636      638       +2     
============================================
  Files            74       74              
  Lines          2002     2024      +22     
  Branches        257      258       +1     
============================================
+ Hits           1605     1627      +22     
  Misses          251      251              
  Partials        146      146

@bootstraponline bootstraponline merged commit 10d5182 into master Mar 13, 2019

4 checks passed

ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
codecov/project 80.38% (+0.21%) compared to 569e1dd
Details
license/cla Contributor License Agreement is signed.
Details

@bootstraponline bootstraponline deleted the compat branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.