Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exit code reporting #536

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@bootstraponline
Copy link
Contributor

bootstraponline commented Apr 3, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #536 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #536      +/-   ##
============================================
+ Coverage     79.29%   79.59%   +0.29%     
- Complexity      557      561       +4     
============================================
  Files            77       77              
  Lines          2106     2102       -4     
  Branches        279      276       -3     
============================================
+ Hits           1670     1673       +3     
+ Misses          267      265       -2     
+ Partials        169      164       -5

@bootstraponline bootstraponline merged commit bd6e444 into master Apr 3, 2019

4 checks passed

ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
codecov/project 79.59% (+0.29%) compared to 639ae4b
Details
license/cla Contributor License Agreement is signed.
Details

@bootstraponline bootstraponline deleted the matrix_rollup branch Apr 3, 2019

@gtroshin

This comment has been minimized.

Copy link

gtroshin commented Apr 4, 2019

Will it change the flaky-test-attempts logic somehow? The exit code now is 0 even if there is some matrix failed.

@bootstraponline

This comment has been minimized.

Copy link
Contributor Author

bootstraponline commented Apr 4, 2019

FYI: The matrix roll-up change has been released.

Hmm. FTL said the matrix status should be correct now. They pinged me yesterday.

@bootstraponline

This comment has been minimized.

Copy link
Contributor Author

bootstraponline commented Apr 4, 2019

@gtroshin I tested flank master and I'm getting the correct exit code (1) when the tests fail every time when using flaky-test-attempts. If a test passes at least once then the matrix status will be successful. If there are any issues, let me know. I think everything is working as expected now that FTL has fixed the bug on their side.

@gtroshin

This comment has been minimized.

Copy link

gtroshin commented Apr 5, 2019

@bootstraponline Ok, thank you! Then I will update to 5.0.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.