Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent uploading results for Smart Flank #537

Merged
merged 6 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@elihart
Copy link
Contributor

elihart commented Apr 4, 2019

Hi, thanks for this great library! I noticed that https://github.com/TestArmada/flank/blob/master/docs/smart_flank.md mentioned the possible improvement to disable uploading smart flank results, so I implemented it.

I have recently added Flank to our test suite at Airbnb, and I'd love this support to allow us to run a subset of tests on some branches without overwriting the master set of results.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@elihart elihart force-pushed the elihart:eli-optional_upload branch from a7ed2cf to 6f1819d Apr 4, 2019

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Apr 4, 2019

Thanks! That's definitely a feature we want to support.

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Apr 4, 2019

If you run ./gradlew check locally it should auto fix some of the lint issues.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #537 into master will not change coverage.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #537   +/-   ##
=========================================
  Coverage     79.65%   79.65%           
  Complexity      563      563           
=========================================
  Files            77       77           
  Lines          2109     2109           
  Branches        276      276           
=========================================
  Hits           1680     1680           
  Misses          265      265           
  Partials        164      164
@elihart

This comment has been minimized.

Copy link
Contributor Author

elihart commented Apr 4, 2019

Thanks for the tip, fixed!

I was going off the contributing doc which says to use ./gradlew ktlintFormat, which threw me off. Would be nice to update that.

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Apr 5, 2019

ah, yeah we replaced ktlint with detekt. I'll update the doc

## This can be disabled to prevent new results from overriding previous results.
## Default: true
# smart-flank-upload-enabled: true

## Disables sharding. Useful for parameterized tests.
# disable-sharding: false

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Apr 5, 2019

Contributor

I think for consistency with disable-sharding, I'd like the flag renamed to:

smart-flank-disable-upload

then in the code we can check args.smartFlankDisableUpload instead of !args.smartFlankUploadEnabled.

The description can be written like this:

Disables smart flank JUnit XML uploading. Useful for preventing timing data from being updated.

I'm happy to make both changes if you'd like.

This comment has been minimized.

Copy link
@elihart

elihart Apr 5, 2019

Author Contributor

sure thing, I'll do it

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Apr 5, 2019

Contributor

Perfect, thanks. After that I'll merge the PR.

@elihart elihart force-pushed the elihart:eli-optional_upload branch from 7cfbc94 to aa5b368 Apr 5, 2019

elihart added some commits Apr 5, 2019

@elihart

This comment has been minimized.

Copy link
Contributor Author

elihart commented Apr 5, 2019

All cleaned up, I think it should be good to go. Thanks for the quick review!

Any idea when you might be able to push a new release with this change? I'd love to get it into our app soon.

@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Apr 5, 2019

Awesome work! The Flank release process is fully automated. The snapshot jar is released after every merged PR. The stable releases are auto uploaded after I tag a version in git. I'll tag a 5.1.0 release after merging.

@bootstraponline bootstraponline merged commit d119b44 into TestArmada:master Apr 5, 2019

4 checks passed

ci/bitrise/9767f3e19047d4db/pr Passed - Flank | macOS Public
Details
ci/bitrise/fbdede5ce50cbc21/pr Passed - Flank | Ubuntu Public
Details
codecov/project 79.65% (+0%) compared to 182d0c5
Details
license/cla Contributor License Agreement is signed.
Details
@bootstraponline

This comment has been minimized.

Copy link
Contributor

bootstraponline commented Apr 5, 2019

image

@elihart elihart deleted the elihart:eli-optional_upload branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.