Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional-app-test-apks support #542

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bootstraponline
Copy link
Contributor

bootstraponline commented Apr 10, 2019

Fix #511

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #542 into master will decrease coverage by 0.05%.
The diff coverage is 90.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #542      +/-   ##
============================================
- Coverage     79.58%   79.53%   -0.06%     
- Complexity      563      573      +10     
============================================
  Files            77       79       +2     
  Lines          2111     2135      +24     
  Branches        276      274       -2     
============================================
+ Hits           1680     1698      +18     
  Misses          266      266              
- Partials        165      171       +6
## Include additional app/test apk pairs in the run. If app is omitted, then the top level app is used for that pair.
# additional-app-test-apks:
# - app: ../test_app/apks/app-debug.apk
# test: ../test_app/apks/app-debug-androidTest.apk

This comment has been minimized.

Copy link
@doodla

doodla Apr 10, 2019

Contributor

Have you thought of making test a list, so you don't have a bunch of usages without app?

Something like

- app: ../app.apk
  test:
    - testapk1.apk
    - testapk2.apk

- app: app2.apk
  test:
     - testfinal.apk

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Apr 10, 2019

Author Contributor

I like that idea.

@doodla

This comment has been minimized.

Copy link
Contributor

doodla commented Apr 10, 2019

Did firebase add support for multiple test apks?

@bootstraponline

This comment has been minimized.

Copy link
Contributor Author

bootstraponline commented Apr 10, 2019

Did firebase add support for multiple test apks?

Nope. We talked with the FTL team and this isn't a roadmap priority for them.

I think modules on Android are a good use case for this feature. I've been working with American Express to add support for this use case directly in Flank to unblock them.

@doodla

This comment has been minimized.

Copy link
Contributor

doodla commented Apr 10, 2019

Haven't gone through the code, but are you merging all test apks into a single one?

@bootstraponline

This comment has been minimized.

Copy link
Contributor Author

bootstraponline commented Apr 10, 2019

Haven't gone through the code, but are you merging all test apks into a single one?

Previously flank only allowed one test/app apk. In the new design, Flank accepts an array of test/app apks. The apks aren't merged. If you have one app and a dozen test apks for that single app, now you can get the results within a single flank run.

@doodla

This comment has been minimized.

Copy link
Contributor

doodla commented Apr 10, 2019

Oh of course. You can just trigger multiple test lab runs, each with a different test APK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.