Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes + bumped version. #61

Merged
merged 5 commits into from Jan 31, 2014
Merged

Misc fixes + bumped version. #61

merged 5 commits into from Jan 31, 2014

Conversation

minisu
Copy link
Member

@minisu minisu commented Jan 30, 2014

No description provided.

@minisu
Copy link
Member Author

minisu commented Jan 30, 2014

I plan to release this to Maven Central soon. Please test if you have the time.

@Philipp91
Copy link
Contributor

// EDIT: This is irrelevant, was from a different branch.

I ran it on Ubuntu Linux with Unity, this is what I get:

Running org.loadui.testfx.LabelForTest
java.util.concurrent.TimeoutException: Timeout waiting for task.
at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:276)
...

@minisu
Copy link
Member Author

minisu commented Jan 30, 2014

Damnit, I have to install Unity. It runs fine on my Linux Mint (Cinnamon) box.

@Philipp91
Copy link
Contributor

Sorry, I just realized that this is actually a pull request, so the changes are not on master yet (stupid mistake). I will recheck with the correct branch.

@Philipp91
Copy link
Contributor

On my linux machine I still get some errors. The TestFX unit tests work fine, but my own UI tests do not. Even though I never touched the mouse, the userInputDetected() method was executed. I will debug this later to see if it's a TestFX bug or a bug in my tests.

@Philipp91
Copy link
Contributor

The first problem seems to be related to a "moving target". I have a test that does a lot of things and in the end closes two tabs by clicking their X icons and then closes the window programmatically. Any test executed after that will fail already in its Before-method because a tilt is detected that never happened.

When closing the first tab, its tab header is animated and slowly shrinks, causing the whole tab header of the second tab to move to the left. When clicking this tab header's X, something must go wrong. I can confirm that the tab is properly closed (because my unit test verifies that), but somehow a wrong "lastPoint" is saved or the reset() method is not called, I don't know. The next test fails because it expected (612;101) instead of (575;101). I guess the first coordinates is where the X icon used to be before the animation and the second is where it has been clicked?

Sometimes, I have the same issue on Windows. But it only occurs sometimes there. The window "freezes" until both tabs are closed, so the window never closes before the tab-closing animation finished. Maybe that is why it sometimes works on Windows. When I put "sleep(1000)" after each tab-close command, it works on both Linux and Windows.

I will try to make a TestFX unit test out of this.

@Philipp91
Copy link
Contributor

I can't reproduce this in a plain TestFX UI test, so maybe it has something to do with my test setup. Other than this one I haven't found any errors, so this can be integrated and released.

@minisu
Copy link
Member Author

minisu commented Jan 31, 2014

Ok, thanks!

@minisu minisu closed this Jan 31, 2014
@minisu minisu reopened this Jan 31, 2014
minisu pushed a commit that referenced this pull request Jan 31, 2014
@minisu minisu merged commit 1140c79 into master Jan 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants