Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display create buttons on top if plans or builds > 10 #124

Closed

Conversation

@Kanaduchi
Copy link
Contributor

commented Nov 2, 2017

No description provided.

Kanaduchi added 2 commits Nov 2, 2017
Update buildView.tpl
Display buttons on top if builds count > 10
Update planView.tpl
Display create button on top if plans > 10
@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2017

Please next time open a ticket on mantis of type feature, this allow tracing of new features on release notes

@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2017

Using fixed values (MAGIC NUMBERS) on code is a very bad practice to avoid.
using a config option can seems an overkill but is the way to go

@@ -43,6 +43,13 @@ var del_action=fRoot+'{$deleteAction}';
{include file="inc_update.tpl" result=$sqlResult item="build" user_feedback=$gui->user_feedback}

{* --------------------------------------------------------------------------------- *}
{if count($gui->buildSet) > 10}
<div class="groupBtn">
<form method="post" action="{$createAction}" id="create_build">

This comment has been minimized.

Copy link
@fmancardi

fmancardi Nov 5, 2017

Contributor

it's not ok having TWO html elements with same ID

@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2017

ticket 8125 and 8126

@fmancardi fmancardi closed this Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.