Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Microsoft OAuth provider #188

Open
wants to merge 4 commits into
base: testlink_1_9
from

Conversation

Projects
None yet
2 participants
@nickidw
Copy link

nickidw commented Mar 8, 2019

Changes to add Microsoft OAuth provider. Microsoft configuration does not allow redirect URL with querystring, which is how the current mechanism is built to work. This means a new php page (microsoftoauth.php) is required to receive the OAuth redirect after authentication. Testing using both Microsoft account as well as Azure AD account.

Also fixed bug where login screen was not drawn if OAuth authentication failed for some reason.

@fmancardi

This comment has been minimized.

Copy link
Contributor

fmancardi commented Mar 9, 2019

Hi
Thanks for your help.
In order to add this to the review process I need to ask you:

  1. please create a ticket in mantis.testlink.org describing the new feature
  2. please provide details about what is needed on the cloud side (i.e. you need to have an Office 365 account or what is really needed), in order to allow me to setup a testing environment.

I will wait for these before adding this to the review queu.

regards

@nickidw

This comment has been minimized.

Copy link
Author

nickidw commented Mar 9, 2019

It's a pleasure. I did log a ticket, link is http://mantis.testlink.org/view.php?id=8591. Please let me know if more information is required.

Nicki

@fmancardi

This comment has been minimized.

Copy link
Contributor

fmancardi commented Mar 9, 2019

Would you mind to provide a configuration example on the microsofy account side ?
I need something like the steps to setup oauth when using google, where you use the google https://developers.google.com

thanks a lot

@nickidw

This comment has been minimized.

Copy link
Author

nickidw commented Mar 9, 2019

I've added notes to the ticket explaining the process step by step. http://mantis.testlink.org/view.php?id=8591#c28580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.