Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration with the Kaiten issue tracking system #204

Conversation

Projects
None yet
2 participants
@vinoron
Copy link
Contributor

commented Jul 1, 2019

Add new issue tracker connector to kaiten.io

@squash-labs

This comment has been minimized.

Copy link

commented Jul 1, 2019

Manage this branch in Squash

Test this branch here: https://kaiten-hqkaiten-issue-tracker-ooluv.squash.io
@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Hi
thanks for your contribution.
In order to help me to test it, would you mind to provide simple instructions regarding what and how configure on Kaiten side?

Regards

@vinoron

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

In order to help me to test it, would you mind to provide simple instructions regarding what and how configure on Kaiten side?

Hi, I made a short video, I hope it will be clearer
Part 1. Kaiten side
https://drive.google.com/open?id=1jQKT37dk78Q47k7PdpSfBldQiUo8qe_J

Part 2. Testlink side
https://drive.google.com/open?id=1nVdqD66KPyHMDp-qfxP9ymuCBWlPvYo3

The video is public and does not contain confidential information

@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@vinoron

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Hi!
The user used to integrate creates cards on his own behalf on the Kaiten Board. For convenience, users can use a generic user such as "testlink". Or, each Testlink user (having an account in Kaiten) enters their credentials into the integration settings.

@fmancardi fmancardi merged commit cd7e4f2 into TestLinkOpenSourceTRMS:testlink_1_9 Jul 2, 2019

4 of 5 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer Analysis: 7 new issues, 32 updated code elements – Tests: passed
Details
Sider 7 issues left; visit Sider to review the issues.
Details
security/snyk - third_party/DataTables-1.10.4/package.json (fmancardi (GitHub marketplace)) No manifest changes detected
security/snyk - third_party/chosen/package.json (fmancardi (GitHub marketplace)) No manifest changes detected
@fmancardi

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Hi
I've accepted the PR and then start code review.
a couple of things:

  1. file header @author => this has to have actual author or be blank => I've set to blank
  2. avoid MAGIC NUMBERS => $opt->tagValue->value[2]], // plan => I'm going to refactor this

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.