Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exclude sequences from being used when shuffled #812

Open
wants to merge 8 commits into
base: Dev
from

Conversation

@flagrama
Copy link

commented Aug 2, 2019

Use cases:

I don't like having Learn Song shuffled into fanfares since it kills the bgm track.

Add "Learn Song" to the exclude file.

I still think the Fire Temple Music in OoT 1.0 is offensive even though it isn't (#557)

Add "Fire Temple" to the exclude file and include either a Fire Temple 1.2 or Shadow Temple sequence in the folder.

I have way too many custom sequences and would like to exclude some of them occasionally without having to move the files all over the place

Add your custom song's file name, each on a new line, to the exclude file.

flagrama added some commits Aug 2, 2019

@flagrama

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

Should be a little better now that it isn't "I need to get this written 10 minutes before I generate a seed to stream" code. In theory you should be able to remove all vanilla sequences to force only custom ones now where with the old code you'd likely run into the "too many attempts" error.

flagrama added some commits Aug 5, 2019

Add GUI and Patch File generation support
SearchBox added to GUI to allow excluding vanilla sequences outside of the excluded.txt file
- Allows excluding certain sounds to be available on the website as well
- I'm sorry I broke the nice three column layout for the SFX and don't know how to fix it, please help.

If creating a patch file and all vanilla sequences are excluded it will simply replace all music with No Music and mention in the Cosmetics Log that all music sequences were disabled

If creating a ROM excluding all sequences will raise an error to remove some exclusions or to add custom tracks.
- I assume this is not an issue for the website as I believe it should always be using the Patch methods, but perhaps an edge case where someone tries to exclude all sequences when applying the patch file? If this is an issue I can make some further changes to correct this to something more website friendly.
@flagrama

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

SearchBox added to GUI to allow excluding vanilla sequences outside of the excluded.txt file

  • Allows excluding certain sounds to be available on the website as well
  • I'm sorry I broke the nice three column layout for the SFX and don't know how to fix it, please help.

If creating a patch file and all vanilla sequences are excluded it will simply replace all music with No Music and mention in the Cosmetics Log that all music sequences were disabled

If creating a ROM excluding all sequences will raise an error to remove some exclusions or to add custom tracks.

  • I assume this is not an issue for the website as I believe it should always be using the Patch methods, but perhaps an edge case where someone tries to exclude all sequences when applying the patch file? If this is an issue I can make some further changes to correct this to something more website friendly.

flagrama added some commits Aug 9, 2019

Add custom tracks to GUI, remove using a file for exlcusions
Removed the exclusion file as it is no longer relevant so long as custom tracks can be managed in the GUI

Removed references to exclusion file in README

SearchBox now says "Exclude Music Sequences" instead of "Exclude Vanilla Music Sequences"

Use data_path from Utils for music path

Use No Music path instead of throwing error when all sequences are excluded while generating a ROM
@flagrama

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

Removed the exclusion file as it is no longer relevant so long as custom tracks can be managed in the GUI

Removed references to exclusion file in README

SearchBox now says "Exclude Music Sequences" instead of "Exclude Vanilla Music Sequences"

Use data_path from Utils for music path

Use No Music path instead of throwing error when all sequences are excluded while generating a ROM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.