Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ocarina Songs as Fanfares on successive generations #830

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@flagrama
Copy link

commented Aug 7, 2019

Ocarina Songs were added to the static list of fanfares causing duplicates to appear in the list and fail the assertion that there will only ever be one copy of a fanfare at any time in successive generations using the Generation Count feature.

A new list is now created and is extended to add both fanfares and ocarina songs to the new list and then operate on that new list instead of the static ones.

Fix Ocarina Songs as Fanfares on successive generations
Ocarina Songs were added to the static list of fanfares causing duplicates to appear in the list and fail the assertion that there will only ever be one copy of a fanfare at any time in successive generations using the Generation Count feature.

A new list is now created and is extended to add both fanfares and ocarina songs to the new list and then operate on that new list instead of the static ones.

@TestRunnerSRL TestRunnerSRL merged commit c3945e5 into TestRunnerSRL:Dev Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.