Multi-OS compatibility #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
victorgveloso
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Works on Linux. Although the output seems corrupted. The first row doesn't have all the expected test smells:
App,TestClass,TestFilePath,ProductionFilePath,RelativeTestFilePath,RelativeProductionFilePath,Assertion Roulette,Eager Test
It should be
App,Version,TestFilePath,ProductionFilePath,RelativeTestFilePath,RelativeProductionFilePath,Assertion Roulette,Conditional Test Logic,Constructor Initialization,Default Test,EmptyTest,Exception Catching Throwing,General Fixture,Mystery Guest,Print Statement,Redundant Assertion,Sensitive Equality,Verbose Test,Sleepy Test,Eager Test,Lazy Test,Duplicate Assert,Unknown Test,IgnoredTest,Resource Optimism,Magic Number Test,Dependent Test
The other rows seems even worse:
Queue,QueueTest.java,/home/anon/Universidade/Master/Aserg/Tests/Queue/src/test/java/br/ufmg/aserg/anon/queue/QueueTest.java,/home/anon/Universidade/Master/Aserg/Tests/Queue/src/main/java/br/ufmg/aserg/anon/queue/Queue.java,est.java,java,false,0,false,0
est.java should be ./src/test/java/br/ufmg/aserg/anon/queue/QueueTest.java
java should be ./src/main/java/br/ufmg/aserg/anon/queue/Queue.java
0 should be false
As you can see this row have more "columns" than the first one, but have less columns than it was expected.
|
@victorgveloso you are right, I included by mistake df53159 that only computed assertion roulette and eager test (that I needed for other purposes). Now it calculates everything |
shehan
approved these changes
Jul 1, 2020
shehan
approved these changes
Jul 1, 2020
shehan
approved these changes
Jul 1, 2020
shehan
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out the tool on MacOS and I found out that it was crashing due to the some splits on file paths where the file separator was hard-coded for Windows.
I replaced those occurrences with
File.separatorand it now words for Unix systems.I also wrote the
TestFileTestsuite to check the behavior on both Unix and Windows systems.I did not try to execute the Windows tests tough.
I have a question about the
getTagName()method of theTestFileclass.What is that supposed to do? Inspecting the
Mainit seems it should get the version of the project, but its implementation seems obscure to me.I also modified the
pomfile to package everything from Maven.Thank you very much