Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate() returned value #27

Merged
merged 1 commit into from Apr 23, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

If value is None, it would return None and not False.

@GuillaumeGomez GuillaumeGomez changed the title Fix validate returned value Fix validate() returned value Apr 23, 2022
@Tethik Tethik merged commit a65c5a4 into Tethik:master Apr 23, 2022
@Tethik
Copy link
Owner

Tethik commented Apr 23, 2022

Interesting. Did this cause a security issue upstream? I imagine if code exists like the following it could be bypassed.

if captcha.validate() == False:
    ... # abort
else:
   ... # do stuff

@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch April 24, 2022 09:03
@GuillaumeGomez
Copy link
Contributor Author

It's exactly what happened to me. ^^'

@Tethik
Copy link
Owner

Tethik commented Apr 24, 2022

I see. I'll raise a security advisory in case other users are affected. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants