Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update rich.reconfigure docstring #2472

Merged
merged 1 commit into from Sep 20, 2022
Merged

docs: update rich.reconfigure docstring #2472

merged 1 commit into from Sep 20, 2022

Conversation

willfrey
Copy link
Contributor

@willfrey willfrey commented Aug 17, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Update the docstring for rich.reconfigure. Previously, the docstring said it would accept an instance of rich.console.Console, but it expects positional and keyword arguments that are forward to the initializer for rich.console.Console.

@willfrey
Copy link
Contributor Author

I didn't see any mentions of docstring changes in CHANGELOG.md, so I've intentionally not updated those since this is a small, cosmetic change. If you want me to update them, just say the word and I'll add it to this PR.

@willfrey willfrey changed the title Update rich.reconfigure docstring docs: update rich.reconfigure docstring Sep 1, 2022
@willmcgugan
Copy link
Collaborator

Thanks

@willmcgugan willmcgugan merged commit bbbee72 into Textualize:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants