Allow tilde in URL (fixes #3057)

[LukeSavefrogs]

This PR fixes #3057.

Type of changes

• Bug fix
• New feature
• Documentation / docstrings
• Tests
• Other

Checklist

• I've run the latest black with default args on new code.
• I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
• I've added tests for new code.
• I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

[willmcgugan]

Thanks. Can you add test(s) please.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (ea1129a) 98.30% compared to head (956bfa5) 98.30%.
Report is 3 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          74       74           
  Lines        8038     8038           
=======================================
  Hits         7902     7902           
  Misses        136      136           

Flag	Coverage Δ
unittests	98.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
rich/highlighter.py	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LukeSavefrogs]

Thanks. Can you add test(s) please.

Sure, but do you think it's actually needed? It's literally one character in the regex and I don't see tests for other special characters (for example %, $, + and so on).

Just asking anyway, it's not a problem adding an extra line in the tests 😄

[willmcgugan]

You are probably correct, but a regression test is better than "probably".

[LukeSavefrogs]

You are probably correct, but a regression test is better than "probably".

I agree

If you're ok then I'll add the missing tests too, then (like https://example.org/index.html?param1=value1) 😀

[willmcgugan]

Couldn’t hurt!

[LukeSavefrogs]

Done 😀

[willmcgugan]

LGTM

[LukeSavefrogs]

Forgot to run black to change formatting, so I did that just now. 😅

Anyway... Running make format-check shows that there are a lot of files (30) that should be formatted as well: