Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AS_USE_VIDEO flag and subspec for Video #1240

Merged
merged 1 commit into from Nov 21, 2018
Merged

Add AS_USE_VIDEO flag and subspec for Video #1240

merged 1 commit into from Nov 21, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Nov 16, 2018

TLDR: Adding the AS_USE_VIDEO will allow to compile out video support if not needed.

This will go in hand with TextureGroup/Weaver#9 and the the Pull Request on Weaver side needs to land first.

@ghost
Copy link

ghost commented Nov 16, 2018

🚫 CI failed with log

@ghost
Copy link

ghost commented Nov 16, 2018

🚫 CI failed with log

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants