Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Feature: Improve android 10 (IoT) wifi connection.#82

Merged
ThanosFisherman merged 12 commits into
ThanosFisherman:masterfrom
eliaslecomte:snapshot/user_cancelled
Aug 28, 2020
Merged

Feature: Improve android 10 (IoT) wifi connection.#82
ThanosFisherman merged 12 commits into
ThanosFisherman:masterfrom
eliaslecomte:snapshot/user_cancelled

Conversation

@eliaslecomte

@eliaslecomte eliaslecomte commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

This tries to improve the connection on Android 10.

  • catch user cancel event
  • don't use the regular wifi state connection receiver to force certain states on Android 10+
  • update some dependencies
  • unbind after losing wifi connection

Elias Lecomte and others added 4 commits June 10, 2020 17:00
First implementation of bind/unbind with network (android10+) and als…
59bee05 
…o passing the user_cancelled error.
Upgrade gradle-wrapper.properties.
091ace5
@eliaslecomte
Merge pull request #1 from ThanosFisherman/master
324a1fb 
Merge upstream changes.
Merge branch 'master' into snapshot/user_cancelled
c9ff804 
# Conflicts:
#	build.gradle
#	gradle/wrapper/gradle-wrapper.properties
#	wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
ThanosFisherman
ThanosFisherman suggested changes Aug 16, 2020
View reviewed changes

@ThanosFisherman ThanosFisherman left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @eliaslecomte Please have a look at my comments and let me know your opinion when you find some time.
I still haven't gotten an Android 10 device to test the IoT connection so I'm not even sure whether some of my comments are valid or not.

Comment thread wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java Outdated
Comment thread wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java Outdated
Comment thread wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java Outdated
Comment thread wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java Outdated
Comment thread wifiutils/src/main/java/com/thanosfisherman/wifiutils/android10/DisconnectCallback.java Outdated
Comment thread ...s/src/main/java/com/thanosfisherman/wifiutils/android10/Android10WifiConnectionReceiver.java Outdated
This was referenced Aug 17, 2020
Open
Open
@ThanosFisherman

ThanosFisherman commented Aug 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Owner

Looks better/clearer now overall. I'll proceed on a merge soon. Thanks for your efforts.

@eliaslecomte

eliaslecomte commented Aug 28, 2020

Copy link
Copy Markdown
Contributor Author

Thanks :-), I am currently testing on multiple devices.

@ThanosFisherman ThanosFisherman merged commit beecb6c into ThanosFisherman:master Aug 28, 2020
@KoustuvGanguly

KoustuvGanguly commented Jul 21, 2022

Copy link
Copy Markdown

HI @ThanosFisherman @eliaslecomte is this available in version 1.6.5? I am facing issues when connecting to IOT devices in android 10. In the system popup if I click connect it doesn't work however if I click cancel it works. Only way to bypass is by taking the in background and again bringing in foreground. I am using 1.6.5 version of this Wifiutil . It's urgent would like to get response from you . Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ThanosFisherman ThanosFisherman ThanosFisherman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliaslecomte @ThanosFisherman @KoustuvGanguly