Feature: Improve android 10 (IoT) wifi connection. #82
Conversation
…o passing the user_cancelled error.
Merge upstream changes.
# Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties # wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
There was a problem hiding this comment.
Hello @eliaslecomte Please have a look at my comments and let me know your opinion when you find some time.
I still haven't gotten an Android 10 device to test the IoT connection so I'm not even sure whether some of my comments are valid or not.
wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/WifiUtils.java
Outdated
Show resolved
Hide resolved
wifiutils/src/main/java/com/thanosfisherman/wifiutils/android10/DisconnectCallback.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/thanosfisherman/wifiutils/android10/Android10WifiConnectionReceiver.java
Outdated
Show resolved
Hide resolved
… disconnect/remove usage of it.
…Utils. Catch broken android 10 implementations.
|
Looks better/clearer now overall. I'll proceed on a merge soon. Thanks for your efforts. |
|
Thanks :-), I am currently testing on multiple devices. |
|
HI @ThanosFisherman @eliaslecomte is this available in version 1.6.5? I am facing issues when connecting to IOT devices in android 10. In the system popup if I click connect it doesn't work however if I click cancel it works. Only way to bypass is by taking the in background and again bringing in foreground. I am using 1.6.5 version of this Wifiutil . It's urgent would like to get response from you . Thanks. |
This tries to improve the connection on Android 10.