passThru via annotations bug

[jeancz]

Problem:
Commit c395d035a5341332d57920ee9384437babcd2970 introduces a bug. For some reason, the order of property setting via the set method has changed. As a result, the passThru flag does not work correctly when using annotations.

Solution:
Revert the aforementioned commit.

[janpecha]

Hello, what is your use-case? Can you provide a code sample?

[jeancz]

A good example could be type conversion.

/**
 * @property int $id m:passThru(toInt)
 */
class Author extends LeanMapper\Entity
{
	protected function toInt($value): int
	{
		return (int) $value;
	}
}

$author = new Author();
$author->assign([
   'id' => '1',
]);

Leanmapper fails here because type checking happens first, and only then does the actual conversion take place.

[janpecha]

Hi, I still think about it...

I don't think it's bug in LM (from my point of view) and I know that your solution works in some previous versions.

My points are:

• I want to move LM to modern PHP
• Modern PHP means more strictness type handling
• Assignment of string type value to property of integer type doesn't make sense (it's bug IMHO)
• It's better (but complicated) to use setters for this use-case.

But maybe it is too masive BC break.

So I will revert the change in 4.x and this strict behavior of passThru will be included in next major version.

[janpecha]

Released Lean Mapper 4.2.1

[jeancz]

I agree that we should all avoid anonymous types. In my case, it's an older project, and it doesn't deserve a major refactoring.

Thanks