New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity: fixed passthru setter, added test #118

Merged
merged 2 commits into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@janpecha
Collaborator

janpecha commented Jan 25, 2018

The fix for the same issue as in #117 but in another way and with tests.

@dakujem

This comment has been minimized.

Show comment
Hide comment
@dakujem

dakujem Jan 25, 2018

Contributor

Isn't this EXACTLY the same as in #117 only written with more characters? 🙄

Contributor

dakujem commented Jan 25, 2018

Isn't this EXACTLY the same as in #117 only written with more characters? 🙄

@janpecha

This comment has been minimized.

Show comment
Hide comment
@janpecha

janpecha Jan 25, 2018

Collaborator

Yes :) It is old commit from my WIP PR on implicit passThru. I sent it, because it has tests.

Collaborator

janpecha commented Jan 25, 2018

Yes :) It is old commit from my WIP PR on implicit passThru. I sent it, because it has tests.

@janpecha janpecha added this to the Stable 3.2.0 milestone Apr 12, 2018

@janpecha janpecha merged commit f2e600f into Tharos:develop Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@janpecha janpecha deleted the inlm:pr/fix-passthru branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment