Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
EntityReflection provider #141
I like these changes
Allow me to make one request:
Even though I would most probably approach the "EntityReflection issue" differenly, using a factory for the whole
// what I would do static::$reflections[$class][$mapperClass] = static::getReflectionFactory()->create($class, $mapperClass) ;
All in all, good job!
If I understand correctly, it isn't needed - just call
Yeah, factory was first idea but it isn't so easy. It requires rewrite architecture of EntityReflection completely. This PR is "compromise solution".
IMHO it's ok, because it provides informations for reflection. Alternative we can rename interface to