Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository: creating entities uses table from parameter #148

Conversation

Projects
None yet
2 participants
@leninzprahy
Copy link
Contributor

commented May 7, 2019

Method createEntities have parameter $table, but the primary key retrieval function did not use it.
No tests, sorry.

Creating entities uses table from parameter
Method createEntities have parameter $table, but the primary key retrieval function did not use it.
@janpecha

This comment has been minimized.

Copy link

commented on c223ac7 May 5, 2019

Ahoj, poslal by to prosím jako PR do https://github.com/Tharos/LeanMapper? Pokud by to bylo i s testem, bylo by to ideální. Díky :)

@janpecha

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

Ok, thanks! I have question - what's your use-case?

@leninzprahy

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

I have two tables (e.g. products and products_category) and I want use only one repository, with shared code.

Otherwise, in the createEntity method, the $table parameter is used to get the primary key, so it will be unified (in methods createEntity and createEntities).

@janpecha

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

Ok thanks. Can you please change commit message to:

Repository: creating entities uses table from parameter

Method createEntities have parameter $table, but the primary key retrieval function did not use it.

@leninzprahy leninzprahy changed the title Repository: Creating entities uses table from parameter Repository: creating entities uses table from parameter May 14, 2019

@janpecha

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

Merged as 5e4d1aa.

@janpecha janpecha closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.