From 0b45c257da27e0faee9d5cd3f5bad45d3975fd50 Mon Sep 17 00:00:00 2001
From: keegansmith21 <keegan.r.s21@gmail.com>
Date: Thu, 4 Jul 2024 07:41:16 +0000
Subject: [PATCH] don't create persistent volume manually

---
 observatory_platform/google/gke.py | 34 +++++++++++++++---------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/observatory_platform/google/gke.py b/observatory_platform/google/gke.py
index f7ae3aa1c..90eb2ad4c 100644
--- a/observatory_platform/google/gke.py
+++ b/observatory_platform/google/gke.py
@@ -35,23 +35,23 @@ def gke_create_volume(*, kubernetes_conn_id: str, volume_name: str, size_gi: int
 
     # Create the PersistentVolume
     capacity = {"storage": f"{size_gi}Gi"}
-    pv = client.V1PersistentVolume(
-        api_version="v1",
-        kind="PersistentVolume",
-        metadata=client.V1ObjectMeta(
-            name=volume_name,
-            # TODO: supposed to use this user for the persistent volume but doesn't seem to do anything
-            # annotations={"pv.beta.kubernetes.io/uid": f"{uid}", "pv.beta.kubernetes.io/gid": f"{uid}"}
-        ),
-        spec=client.V1PersistentVolumeSpec(
-            capacity=capacity,
-            access_modes=["ReadWriteOnce"],
-            persistent_volume_reclaim_policy="Retain",
-            storage_class_name="standard",
-            gce_persistent_disk=client.V1GCEPersistentDiskVolumeSource(pd_name=volume_name),
-        ),
-    )
-    v1.create_persistent_volume(body=pv)
+    # pv = client.V1PersistentVolume(
+    #     api_version="v1",
+    #     kind="PersistentVolume",
+    #     metadata=client.V1ObjectMeta(
+    #         name=volume_name,
+    #         # TODO: supposed to use this user for the persistent volume but doesn't seem to do anything
+    #         # annotations={"pv.beta.kubernetes.io/uid": f"{uid}", "pv.beta.kubernetes.io/gid": f"{uid}"}
+    #     ),
+    #     spec=client.V1PersistentVolumeSpec(
+    #         capacity=capacity,
+    #         access_modes=["ReadWriteOnce"],
+    #         persistent_volume_reclaim_policy="Retain",
+    #         storage_class_name="standard",
+    #         gce_persistent_disk=client.V1GCEPersistentDiskVolumeSource(pd_name=volume_name),
+    #     ),
+    # )
+    # v1.create_persistent_volume(body=pv)
 
     # Create PersistentVolumeClaim
     namespace = hook.get_namespace()