Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
jdddog committed Apr 28, 2023
1 parent 57c9a0d commit 7fdf53e
Showing 1 changed file with 19 additions and 23 deletions.
42 changes: 19 additions & 23 deletions tests/observatory/platform/test_observatory_environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -544,46 +544,42 @@ def test_assert_table_content(self):
test_case = ObservatoryTestCase()
table_id = f"{self.project_id}.{dataset_id}.{table_name}"
expected_content = [
{"first_name": "Gisella", "last_name": "Derya", "dob": str(datetime(1997, 7, 1).date())},
{"first_name": "Adelaida", "last_name": "Melis", "dob": str(datetime(1980, 9, 3).date())},
{"first_name": "Melanie", "last_name": "Magomedkhan", "dob": str(datetime(1990, 3, 1).date())},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": str(datetime(1970, 1, 8).date())},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": str(datetime(2001, 2, 1).date())},
{"first_name": "Gisella", "last_name": "Derya", "dob": datetime(1997, 7, 1).date()},
{"first_name": "Adelaida", "last_name": "Melis", "dob": datetime(1980, 9, 3).date()},
{"first_name": "Melanie", "last_name": "Magomedkhan", "dob": datetime(1990, 3, 1).date()},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": datetime(1970, 1, 8).date()},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": datetime(2001, 2, 1).date()},
]
test_case.assert_table_content(table_id, expected_content)

# Check that BigQuery table is not empty
table_id = f"{self.project_id}.{dataset_id}.{table_name}"
test_case.assert_table_content(table_id)
test_case.assert_table_content(table_id, expected_content, "first_name")

# Check that BigQuery table doesn't exist
with self.assertRaises(AssertionError):
table_id = f"{self.project_id}.{dataset_id}.{random_id()}"
test_case.assert_table_content(table_id, expected_content)
test_case.assert_table_content(table_id, expected_content, "first_name")

# Check that BigQuery table has extra rows
with self.assertRaises(AssertionError):
table_id = f"{dataset_id}.{table_name}"
expected_content = [
{"first_name": "Gisella", "last_name": "Derya", "dob": str(datetime(1997, 7, 1).date())},
{"first_name": "Adelaida", "last_name": "Melis", "dob": str(datetime(1980, 9, 3).date())},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": str(datetime(1970, 1, 8).date())},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": str(datetime(2001, 2, 1).date())},
{"first_name": "Gisella", "last_name": "Derya", "dob": datetime(1997, 7, 1).date()},
{"first_name": "Adelaida", "last_name": "Melis", "dob": datetime(1980, 9, 3).date()},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": datetime(1970, 1, 8).date()},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": datetime(2001, 2, 1).date()},
]
test_case.assert_table_content(table_id, expected_content)
test_case.assert_table_content(table_id, expected_content, "first_name")

# Check that BigQuery table has missing rows
with self.assertRaises(AssertionError):
table_id = f"{self.project_id}.{dataset_id}.{table_name}"
expected_content = [
{"first_name": "Gisella", "last_name": "Derya", "dob": str(datetime(1997, 7, 1).date())},
{"first_name": "Adelaida", "last_name": "Melis", "dob": str(datetime(1980, 9, 3).date())},
{"first_name": "Melanie", "last_name": "Magomedkhan", "dob": str(datetime(1990, 3, 1).date())},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": str(datetime(1970, 1, 8).date())},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": str(datetime(2001, 2, 1).date())},
{"first_name": "Extra", "last_name": "Row", "dob": str(datetime(2001, 2, 1).date())},
{"first_name": "Gisella", "last_name": "Derya", "dob": datetime(1997, 7, 1).date()},
{"first_name": "Adelaida", "last_name": "Melis", "dob": datetime(1980, 9, 3).date()},
{"first_name": "Melanie", "last_name": "Magomedkhan", "dob": datetime(1990, 3, 1).date()},
{"first_name": "Octavia", "last_name": "Tomasa", "dob": datetime(1970, 1, 8).date()},
{"first_name": "Ansgar", "last_name": "Zorion", "dob": datetime(2001, 2, 1).date()},
{"first_name": "Extra", "last_name": "Row", "dob": datetime(2001, 2, 1).date()},
]
test_case.assert_table_content(table_id, expected_content)
test_case.assert_table_content(table_id, expected_content, "first_name")

def test_assert_file_integrity(self):
"""Test assert_file_integrity"""
Expand Down

0 comments on commit 7fdf53e

Please sign in to comment.