Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default write disposition #623

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Changed default write disposition #623

merged 1 commit into from
Jun 26, 2023

Conversation

keegansmith21
Copy link
Contributor

Default table load probably shouldn't be destructive (as I've discovered the hard way).

@keegansmith21 keegansmith21 requested a review from jdddog June 22, 2023 03:08
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (1e16b5c) 87.77% compared to head (b3a5c03) 87.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #623      +/-   ##
===========================================
- Coverage    87.77%   87.73%   -0.04%     
===========================================
  Files           38       38              
  Lines         5169     5169              
  Branches       623      623              
===========================================
- Hits          4537     4535       -2     
- Misses         496      501       +5     
+ Partials       136      133       -3     
Impacted Files Coverage Δ
...ervatory-platform/observatory/platform/bigquery.py 89.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdddog jdddog force-pushed the fix/bq_load_default branch from a7411c4 to b3a5c03 Compare June 26, 2023 02:05
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan, that looks like a safer option. I've updated a couple of workflows in Academic Observatory to work in line with this: The-Academic-Observatory/academic-observatory-workflows#170

@jdddog jdddog merged commit ad17898 into develop Jun 26, 2023
@jdddog jdddog deleted the fix/bq_load_default branch June 26, 2023 04:50
jdddog pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants