fix: i18n improvements #323
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request updates several locale files and a settings page component. It modifies existing translation strings by removing language options and adding new ones for temperature units (Celsius and Fahrenheit). The settings page has been updated to replace hardcoded temperature labels with dynamic translation calls, ensuring alignment with the updated locale files. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant S as Settings Page
participant T as Translation Service/Locale Files
U->>S: Load settings page
S->>T: translationSettings("celsius")
T-->>S: Localized "Celsius" string
S->>T: translationSettings("fahrenheit")
T-->>S: Localized "Fahrenheit" string
S->>U: Render settings page with updated labels
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used📓 Learnings (1)apps/web/src/locales/id.ts (1)⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://weather-app-git-i18n-improvements-creative-programming-group.vercel.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/web/src/locales/de.ts(1 hunks)apps/web/src/locales/en.ts(1 hunks)apps/web/src/locales/id.ts(1 hunks)apps/web/src/locales/zh-CN.ts(1 hunks)apps/web/src/pages/settings/index.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
apps/web/src/locales/zh-CN.ts (1)
37-38: LGTM! Temperature unit translations are accurate.The Chinese translations for Celsius (摄氏度) and Fahrenheit (华氏度) are correct and consistent with other locale files.
apps/web/src/locales/en.ts (1)
37-38: LGTM! Temperature units and language names are accurate.
- Temperature unit translations are correct.
- Language names now use native names (e.g., "Deutsch" instead of "German"), which is a good i18n practice.
Also applies to: 41-42
apps/web/src/locales/id.ts (1)
40-42: LGTM! Language names are now using native names.The language names have been correctly updated to use native names instead of Indonesian translations.
apps/web/src/locales/de.ts (1)
37-38: LGTM! Temperature units and language names are accurate.
- Temperature unit translations are correct.
- Language names now use native names (e.g., "English" instead of "Englisch"), which is a good i18n practice.
Also applies to: 40-40, 42-42
apps/web/src/pages/settings/index.tsx (2)
55-57: LGTM! Good i18n implementation.The change correctly implements internationalization for the Celsius temperature label while maintaining the standardized unit symbol.
68-70: LGTM! Good i18n implementation.The change correctly implements internationalization for the Fahrenheit temperature label while maintaining the standardized unit symbol.
Summary by CodeRabbit