Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eqy check #1447

Merged
merged 54 commits into from
Sep 23, 2023
Merged

Eqy check #1447

merged 54 commits into from
Sep 23, 2023

Conversation

openroadie
Copy link
Contributor

@openroadie openroadie commented Sep 7, 2023 •
edited
Loading

Adding eqy checks into ORFS with help from the eqy team on how to structure the input config file.

openroadie and others added 10 commits September 6, 2023 13:38
@openroadie
Add modified verilog files for equivalence checking
45bbd47 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
remove superfluous file
8f997af 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
add code to write out equivalence check config file and run the equiv…
a03fe83 
…alence check post repair_timing

Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
enable equivalence checks after repair_timing
510b3de 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
WiP
77fc3de 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
Merge branch 'The-OpenROAD-Project:master' into eqy_check
1e5a725
@openroadie
enhance to do equivalence check
edc137a 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
Merge branch 'eqy_check' of https://github.com/openroadie/OpenROAD-fl…
79667e1 
…ow-scripts into eqy_check
@openroadie
enable equivalence checking
5577c92 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
enable equivalence checking
50e2af5 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
Copy link
Contributor Author

@vvbandeira This PR cannot be merged until the CI/CD container has these repos installed as the default (sudo make install).
Please follow the order the repos are mentioned in:

https://github.com/YosysHQ/yosys
https://github.com/YosysHQ/eqy
https://github.com/YosysHQ/sby

Please do let me know if I can help in any way. Thx !

maliberty
maliberty reviewed Sep 7, 2023
View reviewed changes
flow/scripts/load.tcl Outdated Show resolved Hide resolved
maliberty
maliberty reviewed Sep 7, 2023
View reviewed changes
flow/scripts/load.tcl Outdated Show resolved Hide resolved
maliberty
maliberty reviewed Sep 7, 2023
View reviewed changes
flow/scripts/load.tcl Outdated Show resolved Hide resolved
maliberty
maliberty reviewed Sep 7, 2023
View reviewed changes
flow/scripts/load.tcl Outdated Show resolved Hide resolved
maliberty
maliberty reviewed Sep 7, 2023
View reviewed changes
flow/scripts/load.tcl Outdated Show resolved Hide resolved
@openroadie
use -remove_cells to remove TAP cells
f2324d4 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
handle subdirectories in the log dir during cts_clean
f622571 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
address PR comments
e16cee4 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@vijayank88
Copy link
Contributor

@openroadie
Is that doing logic equivalence check?
Also plz update EQUIVALENCE_CHECK variable to part of FlowVariables.md with descriptions.

@openroadie openroadie mentioned this pull request Sep 9, 2023
Merged
openroadie and others added 7 commits September 10, 2023 00:11
@openroadie
add verilog cells for nangate45
e9aab45 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
add missing/used cells
46d5876 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
add more cells
76022c6 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
ci: enable eqy
d171297 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
@openroadie
add REMOVE_CELLS_FOR_EQY
2df7cea 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
add doc for new variables
906d9c7 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
@openroadie
Merge branch 'eqy_check' of https://github.com/openroadie/OpenROAD-fl…
b2be310 
…ow-scripts into eqy_check
@openroadie openroadie marked this pull request as ready for review September 19, 2023 19:02
openroadie and others added 13 commits September 20, 2023 09:46
@openroadie
put in a placeholder for modified eqy script for sky130hd
26aab2c 
Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Bump OR submodule
eb964ab 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
script: remove load.tcl commented code
a0d89b5 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
script: try to keep commented code
b0c306e 
This reverts commit a0d89b5.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
etc: add pip dependencies, remove dups w/OR
db8d5de 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
ci: enable python38
3818701 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Bump OR submodule
97815b7 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
typo
ac998e8 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
ci: fix args eval
4f2410d 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
etc: enable python before pip install
2da3819 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
ci: rm source env.sh
4fde8d2 
This conflicts yosys versions and causes eqy to not work

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
etc: toggle undefined var for external scritps
9ec87f5 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
ci: remove extra semicolons
a5da66a 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
vvbandeira
vvbandeira reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@vvbandeira vvbandeira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this small question. CI is in a shape where is good to merge the PR, please let me know when to merge -- I would like to do a "squash and merge" due to the number of commits.

Edit: maybe add an exclude to the 4_eqy_output folder so as to not save in CI as it contains a lot of files which is slowing down the pipeline?

flow/scripts/cts.tcl Show resolved Hide resolved
@openroadie
Copy link
Contributor Author

@vvbandeira this is good to merge from my point of view. But CI/CD is still failing (pr-head) as far as I can see.

Vitor Bandeira added 3 commits September 23, 2023 17:01
ci: exclude 4_eqy_output from save artifacts
af26932 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
cts: save eqy verilog at RESULTS_DIR
65a21d7 
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Revert "cts: save eqy verilog at RESULTS_DIR"
7b9261e 
This reverts commit 65a21d7.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
@vvbandeira vvbandeira merged commit 3c48244 into The-OpenROAD-Project:master Sep 23, 2023
6 of 9 checks passed
habibayassin pushed a commit to habibayassin/OpenROAD-flow-scripts that referenced this pull request Oct 8, 2023
@openroadie @habibayassin
Eqy check (The-OpenROAD-Project#1447)
0f3d2f7 
* Add modified verilog files for equivalence checking
* Add code to write out equivalence check config file and run the equivalence check post repair_timing
* Enable equivalence checks after repair_timing
* Use -remove_cells to remove TAP cells
* Handle subdirectories in the log dir during cts_clean
* Add verilog cells for nangate45
* Add missing/used cells
* Add REMOVE_CELLS_FOR_EQY
* Add doc for new variables
* Add new variables for skipping cells for equivalence checks+cleanup
* Fixes in flip flop definitions
* Enable sky130hd/gcd eqy check
* Bump OR submodule
* etc: enable python before pip install
* etc: add pip dependencies, remove dups w/OR
* ci: enable python38
* ci: EQUIVALENCE_CHECK will be enabled per design
* ci: remove source env.sh from test_helper and GHA
        This conflicts yosys versions and causes eqy not to work
* ci: exclude 4_eqy_output from save artifacts

---

Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Co-authored-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: habibayassin <habibayassin@aucegypt.edu>
habibayassin pushed a commit to habibayassin/OpenROAD-flow-scripts that referenced this pull request Oct 8, 2023
@openroadie @habibayassin
Eqy check (The-OpenROAD-Project#1447)
a297ac6 
* Add modified verilog files for equivalence checking
* Add code to write out equivalence check config file and run the equivalence check post repair_timing
* Enable equivalence checks after repair_timing
* Use -remove_cells to remove TAP cells
* Handle subdirectories in the log dir during cts_clean
* Add verilog cells for nangate45
* Add missing/used cells
* Add REMOVE_CELLS_FOR_EQY
* Add doc for new variables
* Add new variables for skipping cells for equivalence checks+cleanup
* Fixes in flip flop definitions
* Enable sky130hd/gcd eqy check
* Bump OR submodule
* etc: enable python before pip install
* etc: add pip dependencies, remove dups w/OR
* ci: enable python38
* ci: EQUIVALENCE_CHECK will be enabled per design
* ci: remove source env.sh from test_helper and GHA
        This conflicts yosys versions and causes eqy not to work
* ci: exclude 4_eqy_output from save artifacts

---

Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Co-authored-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: habibayassin <habibayassin@aucegypt.edu>
@huang-kaixin
Copy link

Adding eqy checks into ORFS with help from the eqy team on how to structure the input config file.
May I ask why adding eqy checks is necessary? I encountered many "110 could not execute" eqy "errors while running gcd.

@maliberty
Copy link
Member

eqy is trying to prove that OR hasn't introduced any logic errors in the course of optimization. We did hit one such case a while ago and wanted to have some checking.

@refaay
Copy link

refaay commented Dec 5, 2023

I am trying to build and execute a fresh clone of ORFS.
I am also facing the same issue "Error: cts.tcl, 113 couldn't execute "eqy": no such file or directory" while running "make" in "OpenROAD-flow-scripts/flow" and then it breaks.
How do I fix it?

@maliberty
Copy link
Member

@vvbandeira please help @refaay with eqy

habibayassin pushed a commit to habibayassin/OpenROAD-flow-scripts that referenced this pull request Mar 2, 2024
@openroadie @habibayassin
Eqy check (The-OpenROAD-Project#1447)
46aa5b7 
* Add modified verilog files for equivalence checking
* Add code to write out equivalence check config file and run the equivalence check post repair_timing
* Enable equivalence checks after repair_timing
* Use -remove_cells to remove TAP cells
* Handle subdirectories in the log dir during cts_clean
* Add verilog cells for nangate45
* Add missing/used cells
* Add REMOVE_CELLS_FOR_EQY
* Add doc for new variables
* Add new variables for skipping cells for equivalence checks+cleanup
* Fixes in flip flop definitions
* Enable sky130hd/gcd eqy check
* Bump OR submodule
* etc: enable python before pip install
* etc: add pip dependencies, remove dups w/OR
* ci: enable python38
* ci: EQUIVALENCE_CHECK will be enabled per design
* ci: remove source env.sh from test_helper and GHA
        This conflicts yosys versions and causes eqy not to work
* ci: exclude 4_eqy_output from save artifacts

---

Signed-off-by: Harsh Vardhan <openroad@chez-vardhan.com>
Co-authored-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: habibayassin <habibayassin@aucegypt.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty left review comments

@rovinski rovinski rovinski left review comments

@vvbandeira vvbandeira vvbandeira left review comments

@tspyrou tspyrou Awaiting requested review from tspyrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openroadie @vijayank88 @huang-kaixin @maliberty @refaay @rovinski @vvbandeira