Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onERC721Received #6

Merged
merged 31 commits into from
Mar 13, 2024
Merged

onERC721Received #6

merged 31 commits into from
Mar 13, 2024

Conversation

YouStillAlive
Copy link
Member

No description provided.

@YouStillAlive YouStillAlive marked this pull request as draft March 4, 2024 08:59
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52a043a) to head (c9219b0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         6    +2     
  Lines          113       153   +40     
  Branches        22        32   +10     
=========================================
+ Hits           113       153   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@YouStillAlive YouStillAlive marked this pull request as ready for review March 11, 2024 11:59
Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good !
there are small things that we can do before the Audit:
split the file into smaller parts (for simple / advance)
and add more documentation on the functions

contracts/Builder/BuilderInternal.sol Outdated Show resolved Hide resolved
contracts/SimpleRefundBuilder/RefundBuilderInternal.sol Outdated Show resolved Hide resolved
contracts/SimpleRefundBuilder/RefundBuilderInternal.sol Outdated Show resolved Hide resolved
@Lomet Lomet merged commit 99388bd into master Mar 13, 2024
6 checks passed
@YouStillAlive YouStillAlive deleted the issue-4 branch March 13, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleRefundBuilder refactor Add onERC721Received option to SimpleRefundBuilder
2 participants