Skip to content

Conversation

@Gagarod
Copy link
Contributor

@Gagarod Gagarod commented Oct 2, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Fixes: #2383

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Gagarod Gagarod requested a review from siriak as a code owner October 2, 2021 09:27
@Gagarod Gagarod changed the title Added MagicSquare.java Fixes:#2383 Added MagicSquare.java Fixes: #2383 Oct 2, 2021
@Gagarod
Copy link
Contributor Author

Gagarod commented Oct 4, 2021

@siriak please check if everything is good to go

@siriak siriak merged commit fb3f3ff into TheAlgorithms:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magic Square | ODD Order

2 participants