Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace List in BFS with Queue #3231

Merged
merged 4 commits into from Aug 28, 2022
Merged

Replace List in BFS with Queue #3231

merged 4 commits into from Aug 28, 2022

Conversation

xdavidliu
Copy link
Contributor

@xdavidliu xdavidliu commented Aug 25, 2022 •
edited

...because it's more efficient while still giving the correct result.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@xdavidliu
Replace List in BFS with Queue
05c4669 
...because it's more efficient while still giving the correct result.
@xdavidliu
Copy link
Contributor Author

Fixes: #3229

siriak
siriak approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) August 28, 2022 05:45
@siriak siriak merged commit 9e37775 into TheAlgorithms:master Aug 28, 2022
@xdavidliu xdavidliu deleted the patch-1 branch August 29, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xdavidliu @siriak