Skip to content

Conversation

@AndresContreras96
Copy link
Contributor

@AndresContreras96 AndresContreras96 commented Jun 9, 2020

157/5000
Hello! I did the select selection algorithm, I saw that it was not implemented yet. Feedback would be very appreciated since it is my first contribution in open source world

@cozek
Copy link
Member

cozek commented Jun 9, 2020

Hi Andres. Overall I like you code style. Nice indentations and good use of variable names.
In the future try adding some documentation to your code, like a brief explanation of the function (which you have done nicely). The expected data type of the function arguments. Take a look at the code style guide in #9 .

Thanks for your contribution.

@cozek cozek merged commit 48e12fa into TheAlgorithms:master Jun 9, 2020
function arrayToSort = select_sort(arrayToSort)
for i=1:length(arrayToSort)
%%smallest element in the unsorted list
minimun_index=i;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? (minimum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants