Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding code coverage threshold defaulted to 80 percent #103

Merged
merged 1 commit into from Aug 27, 2018

Conversation

@TheAngryByrd
Copy link
Owner

TheAngryByrd commented Aug 27, 2018

Proposed Changes

Adds code coverage threshold that fails the build if it goes below it

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd merged commit bcd2bc2 into master Aug 27, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@TheAngryByrd TheAngryByrd mentioned this pull request Aug 27, 2018
0 of 6 tasks complete
TheAngryByrd added a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
TheAngryByrd added a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
TheAngryByrd added a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
@TheAngryByrd TheAngryByrd deleted the 101-coverage-threshold branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.