Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's translate AppImageLauncher! #36

Open
TheAssassin opened this issue May 15, 2018 · 26 comments
Open

Let's translate AppImageLauncher! #36

TheAssassin opened this issue May 15, 2018 · 26 comments
Labels
contributions welcome enhancement

Comments

@TheAssassin
Copy link
Owner

@TheAssassin TheAssassin commented May 15, 2018

In order to provide a more seamless experience for users, AppImageLauncher should be translated!

I will set up a Weblate integration as soon as possible, and would like to see as many users speaking different languages as possible to translate AppImageLauncher's user interface and desktop action titles into many different languages.

I will post a link to the translation portal here as soon as it's available. I will start myself with a German translation of the English text.

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented May 17, 2018

Genial , podrías traducirlo al español!!!=Great, you could translate it into Spanish !!!

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 17, 2018

@Lvaskz just pushed a set of commits that allow us to kick off the translation process. I'll publish details on how you can contribute as soon as possible.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 18, 2018

All right. AppImageLauncher can now be translated! I've taught myself how to use Qt's internationalization framework, implemented a suitable CMake infrastructure, set up the internationalization in the applications themselves, set up the localization (the part where users can contribute translations), everything works fine.

I set up my Weblate instance to allow users to translate the app with a simple web UI. Please use Weblate to translate the application, and don't send PRs directly.

For convenience, GitHub login has been set up for my Weblate instance. But you can as well just register with an e-mail address to create a local account.

https://translate.assassinate-you.net/projects/appimagelauncher/

The German translation is already working fine in the packages built on Travis CI.

I will set up the rest of the tools as components on Weblate tomorrow. I refactored the translations, as it makes more sense to translate the main dialog and the helpers in a single file.

@TheAssassin TheAssassin added enhancement help wanted labels May 18, 2018
@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 19, 2018

Update: desktop actions can now be translated as well.

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented May 21, 2018

Spanish updated already

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 21, 2018

@Lvaskz thanks! Could you please also have a look at https://translate.assassinate-you.net/projects/appimagelauncher/desktop-actions/?

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented May 21, 2018

Done

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 21, 2018

Great. I'm working on #42, so soon with the new version AppImageLauncher will update the desktop files with the new translations.

@dayllenger
Copy link
Contributor

@dayllenger dayllenger commented Jun 8, 2018

Hello, I've just done translations into Russian.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Jun 8, 2018

Thanks! I'll check them later tonight.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Jun 8, 2018

Merged and pushed. Thanks, @dayllenger!

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented Sep 6, 2018

I have noticed that some appimagelauncher dialog are not translated into Spanish. It is supposed that they are all translated by me. Is there something I broke when translating?

@azubieta
Copy link
Collaborator

@azubieta azubieta commented Sep 6, 2018

I'm working on a major GUI remake so that will be ready soon. So please hold on translations a bit.
I'll let you know when it's completed.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Sep 6, 2018

@Lvaskz translations aren't pushed to GitHub automatically. I will update them manually ASAP.

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented Sep 9, 2018

Ok

@maverick74
Copy link
Contributor

@maverick74 maverick74 commented Nov 28, 2018

@TheAssassin

I've finished Portuguese translations, however in "AppImageLauncher UI", since PT-PT = PT can you please copy the PT - that i just did - into the PT-PT (i suppose there is an automatic method for this...)?

Also, on string 13 -
Failed to create temporary copy of type 1 AppImage

wasn't this supposed to be

Failed to create temporary copy of type %1 AppImage ?

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Nov 28, 2018

Thanks a lot.

Doesn't PT-PT fall back to PT normally? If not, I'll copy this in git directly, shouldn't be a problem. I want to avoid having redundant translations, though, normally.

You're right about that string, I will push an updated source string later, then we can fix it in all translations.

@maverick74
Copy link
Contributor

@maverick74 maverick74 commented Nov 28, 2018

Doesn't PT-PT fall back to PT normally?

Yes, it should! But sometimes it doesn't.
What should be was Pt = Portugal and Pt-Br = Portuguese-Brazilian... But there are some places that wrongly uses the pt-pt for portugal... so, i guess it's better we play the safe side ;). But still, you are right on your assumption since Portugal is the place of origin of Pt

You're right about that string, I will push an updated source string later, then we can fix it in all translations.

I've included the %1 in my translation, so i guess i won't have to review it.

no need to thank me :) You are the ones doing a great job!!! This should be default in all Desktops (isn't there a bug for this opened in Plasma/Gnome?)

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Nov 28, 2018

You're right about that string, I will push an updated source string later, then we can fix it in all translations.

I've included the %1 in my translation, so i guess i won't have to review it.

The source string will change, though, so one has to retranslate anyway.

@Lvaskz
Copy link
Contributor

@Lvaskz Lvaskz commented Apr 4, 2019

I'm working on a major GUI remake so that will be ready soon. So please hold on translations a bit.
I'll let you know when it's completed.

Is already finished GUI remake?

@linsui
Copy link
Contributor

@linsui linsui commented Apr 22, 2019

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Apr 23, 2019

@linsui it's a bug in the Qt tools. I didn't get to looking into this yet.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 17, 2019

It's actually not 1 bug in the Qt tools but 2 bugs in Weblate. Anyway, I've had to reinstall Weblate, upgrading didn't work at all. I've fixed the issues. Translating will work again.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented May 19, 2019

@linsui thanks for translating to Chinese. Please have a look also at https://translate.assassinate-you.net/projects/appimagelauncher/desktop-files/, there you can translate the desktop actions' names for updating and removing AppImages.

@TheAssassin TheAssassin added contributions welcome and removed help wanted labels Aug 16, 2019
@ireggiani
Copy link

@ireggiani ireggiani commented Sep 28, 2019

Is this where one would add a translation that makes it so the folder "Applications" changes its name depending on the language of the system? I can't find any way to change that and every time I log onto the system, appimagelauncherd creates an "Applications" folder I do not use. I'd like to change that.

@TheAssassin
Copy link
Owner Author

@TheAssassin TheAssassin commented Sep 28, 2019

Right now we have no means of translating this directory's name. Localized directory names are something quite difficult to handle. For instance, if you change your system language, AppImageLauncher would have to recognize that and rename the old directory, etc. Desktop environments have had to create lots of program code to handle these kinds of situations.

May I ask why you don't use it? If you don't use it, there's no reason to create it, hence we could just stop creating it?

Oh and please open a new issue about it. This is off topic. We can try to find a solution then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome enhancement
Projects
None yet
Development

No branches or pull requests

7 participants