Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow loading match history #61

Closed
Grovbolle opened this issue Jun 12, 2013 · 3 comments
Closed

Slow loading match history #61

Grovbolle opened this issue Jun 12, 2013 · 3 comments
Assignees
Labels

Comments

@Grovbolle
Copy link
Contributor

@Grovbolle Grovbolle commented Jun 12, 2013

The match history of some players have begun loading slowly (For me it was LucifroN). Maybe some sort of "only newest 100" matches as standard.

@TheBB
Copy link
Owner

@TheBB TheBB commented Jun 20, 2013

The problem is that we're displaying ratings. For each match this is two DB lookups. Which is pretty dumb.

Possible fixes:

  • Add a couple of foreign keys from ratings_match to ratings_rating so that we can pull this information together with the match whenever we need it.
  • Just don't display ratings in the match lists. Are they really that interesting anyway?
@Grovbolle
Copy link
Contributor Author

@Grovbolle Grovbolle commented Jun 21, 2013

I say fuck ratings, get bitches

@ghost ghost assigned TheBB Jun 28, 2013
@TheBB
Copy link
Owner

@TheBB TheBB commented Jun 28, 2013

Should be fixed in 2bd5ffc.

@TheBB TheBB closed this Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.