Skip to content

CLI: Bump to cargo-generate v0.23.0#342

Merged
DaAlbrecht merged 2 commits into
TheBevyFlock:mainfrom
Magi3r:Magi3r/issue307
Apr 5, 2025
Merged

CLI: Bump to cargo-generate v0.23.0#342
DaAlbrecht merged 2 commits into
TheBevyFlock:mainfrom
Magi3r:Magi3r/issue307

Conversation

@Magi3r

@Magi3r Magi3r commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Fixes #307

@BD103 BD103 added C-Dependencies A change related to dependencies A-Templates Related to generating projects from templates D-Trivial Nice and easy! A great choice to get started with Bevy CLI S-Needs-Review The PR needs to be reviewed before it can be merged labels Apr 4, 2025
@Magi3r

Magi3r commented Apr 5, 2025

Copy link
Copy Markdown
Contributor Author

Oh dear, seems like its not as trivial as I thought. I should have tested it more properly before submitting the pull request.
cargo-generate/cargo-generate#1443 seems to have rewritten the section that now fails, for compatibility with a breaking change in cargo-util-schemas. However, the version of cargo-util-schemas that was compiled for bevy_cli was still the one before the breaking change. The culprit seems to be their Cargo.toml that still allows the no longer supported version.

@BD103

BD103 commented Apr 5, 2025

Copy link
Copy Markdown
Member

Hi! I noticed that Cargo.lock has not been updated, meaning we're probably still using some old dependencies. Could you run cargo update and push the changes? It may fix the error :)

@BD103 BD103 added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review The PR needs to be reviewed before it can be merged labels Apr 5, 2025
@Magi3r

Magi3r commented Apr 5, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, that fixes the error too. :)

DaAlbrecht
DaAlbrecht approved these changes Apr 5, 2025
View reviewed changes

@DaAlbrecht DaAlbrecht left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I actually just needed that ^^

@DaAlbrecht DaAlbrecht removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Apr 5, 2025
@DaAlbrecht DaAlbrecht merged commit ea02f41 into TheBevyFlock:main Apr 5, 2025
@Magi3r Magi3r deleted the Magi3r/issue307 branch April 5, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaAlbrecht DaAlbrecht DaAlbrecht approved these changes

Assignees

No one assigned

Labels

A-Templates Related to generating projects from templates C-Dependencies A change related to dependencies D-Trivial Nice and easy! A great choice to get started with Bevy CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI: Bump to cargo-generate v0.23.0

3 participants

@Magi3r @BD103 @DaAlbrecht