Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother project generation #83

Merged
merged 2 commits into from Aug 25, 2019

Conversation

@LostMikely
Copy link
Contributor

commented Jul 20, 2019

This new batch file will generate the project and if everything is alright the command line will close itself when it's finished. If there is any error, it will show the error message and then pause.

LostMikely added 2 commits Jul 20, 2019
Smoother project generation
This new batch file will generate the project and if everything is alright the command line will close itself when it's finished. If there is any error, it will show the error message and then pause.
@WhoseTheNerd

This comment has been minimized.

Copy link

commented Jul 22, 2019

Batch files aren't cross-platform so I don't think that Cherno would accept it. Hazel was meant to be cross-platform.

@LovelySanta

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

This PR is just enhancing the batch file we already have.. I don't see why this is an issue, but I like to see all the projects it generated before manualy closing it. I think this is just a preference...

@Gaztin

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2019

I like this. It gives people who run the script directly from explorer a chance to catch errors.

@LovelySanta Since I usually have to re-generate the project files now and then, I always keep a terminal open so I can run my project generation and see the output after.

Edit: It seems I got it backwards, but I still like the change. Most people probably don't care about the output unless there were errors, so choosing to not pause is an improvement in my book.

@CleverSource

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

Was it decided this would be merged? It is such a small change but I think it's a great idea, you don't need to worry about the output unless there is an error. Plus from the looks of things Gaztin agrees this is a good change.

LGTM

@Gaztin Gaztin merged commit 070571c into TheCherno:master Aug 25, 2019

@LovelySanta LovelySanta referenced this pull request Aug 26, 2019
6 of 7 tasks complete

@LovelySanta LovelySanta added this to Merged in Community additions Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.