Publish Developer Snapshots on MavenCentral #369

Open
stephanrauh opened this Issue May 7, 2016 · 12 comments

Projects

In Progress in BootsFaces v1.1.0

4 participants

@stephanrauh
Collaborator
stephanrauh commented May 7, 2016 edited

Every once in a while, I upload an untested developer snapshot of BootsFaces to the Sonatype repository, so you can test bug fixes and new features early.

Important: Do not use these snapshots in production!

https://oss.sonatype.org/content/repositories/snapshots/net/bootsfaces/bootsfaces/1.1.0-SNAPSHOT/

You can access this in your pom.xml after adding a new repository:

     <repositories>
        <repository>
          <id>central</id>
          <url>https://oss.sonatype.org/content/repositories/snapshots</url>
          <releases><enabled>true</enabled></releases>
          <snapshots><enabled>true</enabled></snapshots>
        </repository>
    </repositories>

The download coordinates of the 1.1.0 snapshot version are:

<dependency>
    <groupId>net.bootsfaces</groupId>
    <artifactId>bootsfaces</artifactId>
    <version>1.1.0-SNAPSHOT</version>
    <scope>compile</scope>
</dependency>
@zhedar zhedar added meta Maven labels May 7, 2016
@stephanrauh
Collaborator

Just pushed a new version of BootsFaces 0.9.0-SNAPSHOT on Maven Central.

@stephanrauh
Collaborator

Just uploaded another snapshot of BootsFaces 0.9.0. It contains a lot of improvements to the dataTable.

@stephanrauh
Collaborator

Just uploaded a 0.9.1-SNAPSHOT to Maven Central. Basically, it's a hotfix addressing the Java 6 and 7 incompatibility. More details at https://github.com/TheCoder4eu/BootsFaces-OSP/milestone/14?closed=1

@mannan4net

Hi Team, Tried to use the snapshot for one of the issue for datatable resolved but facing issues.

Failed to execute goal on project MavenConfTest: Could not resolve dependencies for project com.mycompany:MavenConfTest:war:1.0-SNAPSHOT: Failure to find net.bootsfaces:bootsfaces:jar:1.0.0-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced ->

Please help to get the snap shot

@stephanrauh
Collaborator

Sorry, the fault is on my side. For some reason, I confused the version numbers. The correct version number of the snapshot is 0.9.2.

@stephanrauh
Collaborator

Just published another snapshot. Anyone who's following this ticket: please test the new version. We're planning to release the new version of BootsFaces by the end of the month, but we're unusually short of resources at the moment, so we appreciate every help we can get.

Thanks in advance!
Stephan

@MitchTalmadge
Contributor
MitchTalmadge commented Oct 28, 2016 edited

I haven't investigated it much, but I found today that many of my navLinks and navCommandLinks had lost their onclick scripts (There is no javascript at all in the HTML when there should be). It confused me since I changed nothing before this happened, then I saw this post, and I don't think it's a coincidence.

Edit: Yep, I just tried using the version I have from my latest commit (c17e9aa) and everything works fine.

The latest snapshot on the repo has broken the navLink and navCommandLink's javascript outputs, UNLESS ajax is set to true. When ajax is set to true, the onclick javascript and such will appear again. However, when ajax is set to true, the pointer cursor becomes a default cursor, which is odd and I can't determine why. (There's no more pointer finger when hovering over the link when ajax is true)

@MitchTalmadge
Contributor
MitchTalmadge commented Oct 28, 2016 edited

I think I found where the problem lies: 50f5716#diff-998cf6177e8580ef5c0b585b0f997b07R178

If ajax is false, javascript is not rendered. This commit caused that broken behavior. I determined that the cursor issue is only on the navLink, and is caused by href not existing when ajax = true. I believe the solution for this would be to add the cursor: pointer; style to navLink regardless of whether ajax is true or not.

@stephanrauh
Collaborator
stephanrauh commented Oct 29, 2016 edited

If I get you right, the problem is that ajax should implicitly be true because you've added an update or execute tag? Or do you simply have an onclick="ajax:myBean.doSomethingFancy()" tag, but no ajax, update or render tags?

@MitchTalmadge
Contributor

Well, the problem is that, let's say I put some code into onclick of navLink. When that navLink is rendered, if ajax is false, the onclick code will not be rendered. However, if ajax is true, then it will be (even though I'm not using ajax at all). The same kinda goes for navCommandLink, except worse. With navCommandLink, if I put a method into action but set ajax to false, the onclick code which fires that action will not be rendered. Once ajax is true (again, not actually using the ajax features), then onclick renders and the action is called.

@MitchTalmadge
Contributor

If you look at 50f5716#diff-998cf6177e8580ef5c0b585b0f997b07R178 I have identified the line of code that causes this behavior. In this commit, the logic was modified (probably accidentally) to where JavaScript is never rendered if ajax is not true.

@stephanrauh
Collaborator

@MitchTalmadge @jottyfan OK, now I've got it. I've solved the bug in the current developer snapshot. Could you run a test, please, and report the result in issue #534 ?

Thanks in advance
Stephan

This was referenced Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment