New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prefect executor): v1 for sandbox use #60
Conversation
WIP, will only merge after we get it working :) |
network_mode: 'bridge' | ||
restart: unless-stopped | ||
environment: | ||
PREFECT__SERVER__HOST: ${PREFECT__SERVER__HOST:-http://host.docker.internal} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just discovered we should also set PREFECT__SERVER__UI__HOST and PREFECT__SERVER__UI__PORT - don't think it matters that much but without them the logged URLs will be incorrect (localhost instead of the actual host). @lmeyerov could you add them in this PR or I can add them later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can also commit to this branch :-) Might do that if I have a more substantial change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do, on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. pushed
@ZiyaoWei Can you review so we can merge? |
|
||
RUN date > /dev/null | ||
#TODO find cleaner way to avoid talking to cloud server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean - the agent needs to query the server, right? Also - just to be clear, this line doesn't talk to the server AFAIK - it switches the backend to "server" so the agent does not query Prefect Cloud.
@lmeyerov I'm a bit confused by one comment but other than that looks good! |
Adds initial docker-compose for operating a prefect executor
Use from
ProjectDomino
parent folder:Next:
-- Change
Dockerfile
to be a layer offgraphistry-blazing
+ whatever else we add-- Healthcheck + prometheus hook