Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prefect executor): v1 for sandbox use #60

Merged
merged 6 commits into from Apr 30, 2020
Merged

Conversation

lmeyerov
Copy link
Contributor

@lmeyerov lmeyerov commented Apr 11, 2020

Adds initial docker-compose for operating a prefect executor

image

Use from ProjectDomino parent folder:

echo "PREFECT__SERVER__HOST=PREFECT.SERVER.IP.HERE" > .env

sudo docker-compose -f ./ProjectDomino/infra/pipelines/docker/docker-compose.yml up -d prefect-agent

sudo docker ps

Next:
-- Change Dockerfile to be a layer off graphistry-blazing + whatever else we add
-- Healthcheck + prometheus hook

bechbd
bechbd previously approved these changes Apr 11, 2020
@lmeyerov
Copy link
Contributor Author

WIP, will only merge after we get it working :)

network_mode: 'bridge'
restart: unless-stopped
environment:
PREFECT__SERVER__HOST: ${PREFECT__SERVER__HOST:-http://host.docker.internal}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just discovered we should also set PREFECT__SERVER__UI__HOST and PREFECT__SERVER__UI__PORT - don't think it matters that much but without them the logged URLs will be incorrect (localhost instead of the actual host). @lmeyerov could you add them in this PR or I can add them later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can also commit to this branch :-) Might do that if I have a more substantial change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do, on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. pushed

@lmeyerov
Copy link
Contributor Author

@ZiyaoWei Can you review so we can merge?


RUN date > /dev/null
#TODO find cleaner way to avoid talking to cloud server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean - the agent needs to query the server, right? Also - just to be clear, this line doesn't talk to the server AFAIK - it switches the backend to "server" so the agent does not query Prefect Cloud.

@ZiyaoWei
Copy link
Collaborator

@lmeyerov I'm a bit confused by one comment but other than that looks good!

@lmeyerov lmeyerov merged commit c70d52b into master Apr 30, 2020
@lmeyerov lmeyerov deleted the dev/prefect-compose branch April 30, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants