New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filestore cleanup is too slow #38
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
We can't remove just offset 0, we must remove all the blocks, but we can just check offset 0, before we build the list to remove (1 bad block, then they're all bad blocks EDIT: This is incorrect, some blocks might be shared by other objects). |
|
|
|
Unfortunately it doesn't take an object, but actually a block, this is a shame. We can use |
…formance increase. Fix for #38, now if a file fails to make it into MFS, it's nuked from the blockstore, then retried. Initial filestore scan made optional (default disabled) and now likely only occurs on failed pin updates (will need testing)
|
Fixed in 78d6721 |

TheDiscordian commentedMar 30, 2021
•
edited
Maybe we can speed it up by only removing offset 0 references, see if that fixes filestore errors just as well, and we can let the gc clean up the rest later.The text was updated successfully, but these errors were encountered: