Skip to content
Browse files

Untracks removed files and adds a basic test.

  • Loading branch information...
1 parent 69957a1 commit e475bd5d71298b58e3d6c94a629444429522709c @TheEmpty committed Nov 20, 2010
Showing with 2 additions and 35 deletions.
  1. +0 −21 lib/devise_rpx_connectable/schema.rb
  2. +2 −0 spec/devise_rpx_connectable_spec.rb
  3. +0 −12 templates/migration.rb
  4. +0 −2 todo.txt
View
21 lib/devise_rpx_connectable/schema.rb
@@ -1,21 +0,0 @@
-# encoding: utf-8
-require 'devise/schema'
-
-module Devise #:nodoc:
- module RpxConnectable #:nodoc:
-
- module Schema
-
- # Database migration schema for RPX.
- #
- def rpx_connectable
- apply_devise_schema ::Devise.rpx_identifier_field, String, :limit => 255
- end
-
- end
- end
-end
-
-Devise::Schema.module_eval do
- include ::Devise::RpxConnectable::Schema
-end
View
2 spec/devise_rpx_connectable_spec.rb
@@ -70,6 +70,8 @@ class RPXNow
@user.should_receive(:on_before_rpx_auto_create).with(RPX_USER_DATA).and_return(true)
@user.should_receive(:save).with({ :validate => false }).and_return(true)
@user.should_receive(:on_before_rpx_success).with(RPX_USER_DATA).and_return(true)
+
+ Identity.should_recieve(:new).and_return(@identity)
@strategy.should_receive(:"success!").with(@user).and_return(true)
View
12 templates/migration.rb
@@ -1,12 +0,0 @@
-class CreateIdentifiers
- def self.up
- create_table(:identifiers) do |t|
- t.column :user_id, :integer
- t.column :identifier, :string
- end
- end
-
- def self.down
- drop_table :identifiers
- end
-end
View
2 todo.txt
@@ -1,2 +0,0 @@
-REMOVE schema.rb
-ADD migration rb

5 comments on commit e475bd5

@emkman
emkman commented on e475bd5 Jan 25, 2012

you need to update your gemspec since you removed schema.rb. I get the following warning rom bundler:

devise_rpx_connectable at /Users/emkman/.rvm/gems/ruby-1.9.2-p290@stickyleaf/bundler/gems/devise_rpx_connectable-e475bd5d7129 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["lib/devise_rpx_connectable/schema.rb"] are not files
@TheEmpty
Owner

authored November 20, 2010 I doubt my fork is still up to date ;)

@emkman
emkman commented on e475bd5 Jan 25, 2012

Yes, as I used it more, I saw that it was never really finished, sorry to bug you about it. It was a step in the right direction however. I fixed all your bugs last night and I am happy with the results. I will push them to my fork soon and let you know in case you are interested.

@TheEmpty
Owner

Yeah let me know and I'll merge or pull from it (not sure what the right term is here). A lot of people use this repo though it's out of date.

@emkman
emkman commented on e475bd5 Jan 25, 2012

I have checked in my changes. I am not sure if you want to pull them because I have added more fields to the Identity model, but I have also fixed important bugs that you probably do want. You were never associating the Identity with its corresponding user and you had unneccessary db calls in some places. Check out: https://github.com/emkman/devise_rpx_connectable/compare/master

Please sign in to comment.
Something went wrong with that request. Please try again.