Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix password hashing #1
pardisfla left a comment
This looks good to me based on what you have changed, although I haven't looked at what you haven't changed to see if there's anything missed.
I'll sync mobiquo with this later and then merge the whole thing as one PR, with the reservation we already discussed regarding plaintext passwords potentially not being cleared from memory. I'm going to look into that further but it doesn't seem like a likely enough attack vector to justify blocking this change.