Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename instances of var node to be more explanatory #24

Closed
dennisguse opened this issue Apr 14, 2019 · 1 comment
Closed

Rename instances of var node to be more explanatory #24

dennisguse opened this issue Apr 14, 2019 · 1 comment
Labels
maintenance simple task

Comments

@dennisguse
Copy link
Member

UIElements (and their siblings) should in createUI() set this.node instead of var node.
@dennisguse dennisguse assigned dennisguse and unassigned dennisguse Apr 14, 2019
@dennisguse
Copy link
Member Author

This is actually invalid.
Everything is correct.

However: var node = should be replaced by renaming node to something more explanatory.

@dennisguse dennisguse added maintenance and removed bug labels May 4, 2019
@dennisguse dennisguse changed the title [BUG] var node = change to this.node = Rename instances of var node to be more explanatory May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance simple task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dennisguse