Skip to content

Update get_function_annotation.hpp - #4651

Merged
hkaiser merged 1 commit into
masterfrom
khuck-patch-4650
May 21, 2020
Merged

Update get_function_annotation.hpp#4651
hkaiser merged 1 commit into
masterfrom
khuck-patch-4650

Conversation

@khuck

@khuck khuck commented May 20, 2020

Copy link
Copy Markdown
Contributor

Fixes #4650

Proposed Changes

  • return nullptr for anonymous tasks so that annotation can annotate them

@khuck

khuck commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

Are the test failures related?

@hkaiser hkaiser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser

hkaiser commented May 21, 2020

Copy link
Copy Markdown
Contributor

In the end I have to take responsibility for the original change that caused this problem. I asked @biddisco to ensure some sensible fallback name is used. Thanks for figuring out what the problem was, @khuck!

@hkaiser

hkaiser commented May 21, 2020

Copy link
Copy Markdown
Contributor

Are the test failures related?

The test failures are unrelated. I'll merge this now.

@hkaiser
hkaiser merged commit ff74f28 into master May 21, 2020
@hkaiser
hkaiser deleted the khuck-patch-4650 branch May 21, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

thread descriptions are broken...again

2 participants