Skip to content

Adapt uninitialized_default_construct and uninitialized_default_construct_n to C++ 20#5415

Merged
msimberg merged 5 commits intoTheHPXProject:masterfrom
Jedi18:adapt_uninit_default_construct
Jul 6, 2021
Merged

Adapt uninitialized_default_construct and uninitialized_default_construct_n to C++ 20#5415
msimberg merged 5 commits intoTheHPXProject:masterfrom
Jedi18:adapt_uninit_default_construct

Conversation

@Jedi18
Copy link
Copy Markdown
Contributor

@Jedi18 Jedi18 commented Jun 27, 2021

Adapted uninitialized _default_construct and uninitialized_default_construct_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

@Jedi18 Jedi18 force-pushed the adapt_uninit_default_construct branch from c42b2e9 to ca8e0e0 Compare June 28, 2021 05:31
@msimberg
Copy link
Copy Markdown
Contributor

retest

@msimberg
Copy link
Copy Markdown
Contributor

launch perftests

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Jul 1, 2021

retest lsu

hkaiser
hkaiser previously approved these changes Jul 3, 2021
Copy link
Copy Markdown
Contributor

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Jul 3, 2021

retest lsu

@msimberg
Copy link
Copy Markdown
Contributor

msimberg commented Jul 5, 2021

@Jedi18 this one also needs rebasing after merging #5389. If you think it'd be easier you can also rebase the C++20 algorithm PRs on top of each other so that you don't have to rebase them after merging. That does mean they should be merged in the order that they are rebased, however.

@Jedi18 Jedi18 force-pushed the adapt_uninit_default_construct branch from ca8e0e0 to d6248e7 Compare July 5, 2021 09:01
@Jedi18
Copy link
Copy Markdown
Contributor Author

Jedi18 commented Jul 5, 2021

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants