[execution] Add schedule_result_t alias template.#5846
Merged
bors[bot] merged 2 commits intoTheHPXProject:masterfrom May 26, 2022
Merged
[execution] Add schedule_result_t alias template.#5846bors[bot] merged 2 commits intoTheHPXProject:masterfrom
bors[bot] merged 2 commits intoTheHPXProject:masterfrom
Conversation
|
Can one of the admins verify this patch? |
SAtacker
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
hkaiser
added
type: enhancement
type: compatibility issue
category: executors
category: senders/receivers
Contributor
|
add to whitelist |
hkaiser
previously approved these changes
Apr 13, 2022
Contributor
hkaiser
left a comment
hkaiser
left a comment
There was a problem hiding this comment.
LGTM, thanks! I would like to wait with merging this until V1.8 has been released (should not take long now).
Contributor
|
Nice! |
- Alias schedule_result_t gives result type of schedule Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
- As per http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/ p2300r4.html#spec-execution.schedulers Point number 2 > 2. Let S be the type of a scheduler ... S is already a scheduler, no need to check Suggested-by: Agustín Bergé <agustinberge@gmail.com> Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
SAtacker
force-pushed
the
schedule_result_t
branch
from
063cadc to
62479f3
Compare
hkaiser
approved these changes
May 26, 2022
Contributor
hkaiser
left a comment
hkaiser
left a comment
There was a problem hiding this comment.
The Windows builder issue was fixed on master, I guess we can ignore it here. LGTM, thanks!
Contributor
|
bors merge |
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Atre shreyasatre16@gmail.com
Any background context you want to provide?