New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuckoo Analyzer requires final slash #113

Closed
crackytsi opened this Issue Oct 20, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@crackytsi
Contributor

crackytsi commented Oct 20, 2017

Request Type

Analyzer

Work Environment

N/A

Description

If Cuckoo runns on a different Port (e.g. 1234) the URL must be in the format:
http://cuckoo.tld:1234/
Note the slash at the end (!).
This is not what the user expects

Steps to Reproduce

Configure Cuckoo API on a different port.

Possible Solutions

Dynamically add the / in the Python script.

@saadkadhi

This comment has been minimized.

Show comment
Hide comment
@saadkadhi

saadkadhi Oct 20, 2017

Contributor

@garanews can you please take charge of this enhancement request when you have time?

Contributor

saadkadhi commented Oct 20, 2017

@garanews can you please take charge of this enhancement request when you have time?

@saadkadhi

This comment has been minimized.

Show comment
Hide comment
@saadkadhi

saadkadhi Oct 25, 2017

Contributor

@garanews when ready can you submit a PR please against develop? Thanks.

Contributor

saadkadhi commented Oct 25, 2017

@garanews when ready can you submit a PR please against develop? Thanks.

@garanews

This comment has been minimized.

Show comment
Hide comment
@garanews

garanews Nov 2, 2017

Contributor

I PRed already against master couple of weeks ago :)

Contributor

garanews commented Nov 2, 2017

I PRed already against master couple of weeks ago :)

@nadouani

This comment has been minimized.

Show comment
Hide comment
@nadouani

nadouani Nov 2, 2017

Contributor

I don't think there is a PR here @garanews, you fixed that on LDO-CERT@9d65fb9 but didn't submit a PR to this repo

Contributor

nadouani commented Nov 2, 2017

I don't think there is a PR here @garanews, you fixed that on LDO-CERT@9d65fb9 but didn't submit a PR to this repo

@garanews

This comment has been minimized.

Show comment
Hide comment
@garanews

garanews Nov 2, 2017

Contributor

You right! Now should be there:
#100

Contributor

garanews commented Nov 2, 2017

You right! Now should be there:
#100

@jeromeleonard jeromeleonard added this to the 1.7.0 milestone Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment