New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crtsh Analyzer: crt.sh result is a nested list #410

Closed
sprungknoedl opened this Issue Jan 22, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@sprungknoedl
Copy link
Contributor

sprungknoedl commented Jan 22, 2019

Request Type

Bug

Work Environment

N/A

Description

The crt.sh result gets wrapped in a list when parsing the json, but the json returned from crt.sh is already a list. This results in a nested list:

Example (truncated for brevity):

{
  "summary": {
    "taxonomies": [
      {
        "predicate": "Certificates",
        "namespace": "crt.sh",
        "value": "1",
        "level": "info"
      }
    ]
  },
  "full": {
    "certobj": {
      "domain": "example.com",
      "result": [
        [
          {
            "not_after": "2020-12-02T12:00:00",
            "min_entry_timestamp": "2018-11-29T13:44:14.118",
            "min_cert_id": 987119772,
            "issuer_ca_id": 1191,
            "name_value": "www.example.com",
            "issuer_name": "C=US, O=DigiCert Inc, CN=DigiCert SHA2 Secure Server CA",
            "not_before": "2018-11-28T00:00:00"
          }
        ]
      ]
    }
  },
  "success": true,
  "artifacts": [],
  "operations": []
}

sprungknoedl added a commit to sprungknoedl/Cortex-Analyzers that referenced this issue Jan 22, 2019

@nadouani nadouani added the bug label Jan 30, 2019

@nadouani nadouani added this to the 1.15.2 milestone Jan 30, 2019

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Jan 30, 2019

This should be fixed by #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment